Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support/wagtail 5.1 #2

Merged
merged 3 commits into from
Nov 17, 2023
Merged

Support/wagtail 5.1 #2

merged 3 commits into from
Nov 17, 2023

Conversation

nickmoreton
Copy link
Collaborator

@nickmoreton nickmoreton commented Oct 3, 2023

Wagtail 5.1 update

There are no changes required to this package for Wagtail 5.1 support.

But I did boost the testing and added some extra version to the matrix.

The current release version should work fine with Wagtail v5.1

@nickmoreton nickmoreton marked this pull request as ready for review October 3, 2023 16:47
Copy link

@katdom13 katdom13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, One optional suggestion.
Thanks

Comment on lines +41 to +75
- python: "3.9"
django: django>=3.2,<4.0
wagtail: wagtail>=4.1,<4.2
- python: "3.9"
django: django>=4.1,<4.2
wagtail: wagtail>=4.2,<5.0
- python: "3.9"
django: django>=4.2,<4.3
wagtail: wagtail>=5.0,<5.1
- python: "3.9"
django: django>=4.2,<4.3
wagtail: wagtail>=5.1,<5.2

- python: "3.10"
django: django>=3.2,<4.0
wagtail: wagtail>=4.1,<4.2
- python: "3.10"
django: django>=4.1,<4.2
wagtail: wagtail>=4.2,<5.0
- python: "3.10"
django: django>=4.2,<4.3
wagtail: wagtail>=5.0,<5.1
- python: "3.10"
django: django>=4.2,<4.3
wagtail: wagtail>=5.1,<5.2

- python: "3.11"
django: django>=4.1,<4.2
wagtail: wagtail>=4.2,<5.0
- python: "3.11"
django: django>=4.2,<4.3
wagtail: wagtail>=5.0,<5.1
- python: "3.11"
django: django>=4.2,<4.3
wagtail: wagtail>=5.1,<5.2
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we make this complete? If not necessary, the above is OK

Suggested change
- python: "3.9"
django: django>=3.2,<4.0
wagtail: wagtail>=4.1,<4.2
- python: "3.9"
django: django>=4.1,<4.2
wagtail: wagtail>=4.2,<5.0
- python: "3.9"
django: django>=4.2,<4.3
wagtail: wagtail>=5.0,<5.1
- python: "3.9"
django: django>=4.2,<4.3
wagtail: wagtail>=5.1,<5.2
- python: "3.10"
django: django>=3.2,<4.0
wagtail: wagtail>=4.1,<4.2
- python: "3.10"
django: django>=4.1,<4.2
wagtail: wagtail>=4.2,<5.0
- python: "3.10"
django: django>=4.2,<4.3
wagtail: wagtail>=5.0,<5.1
- python: "3.10"
django: django>=4.2,<4.3
wagtail: wagtail>=5.1,<5.2
- python: "3.11"
django: django>=4.1,<4.2
wagtail: wagtail>=4.2,<5.0
- python: "3.11"
django: django>=4.2,<4.3
wagtail: wagtail>=5.0,<5.1
- python: "3.11"
django: django>=4.2,<4.3
wagtail: wagtail>=5.1,<5.2
- python: "3.9"
django: django>=3.2,<4.0
wagtail: wagtail>=4.1,<4.2
- python: "3.9"
django: django>=3.2,<4.0
wagtail: wagtail>=4.2,<5.0
- python: "3.9"
django: django>=3.2,<4.0
wagtail: wagtail>=5.0,<5.1
- python: "3.9"
django: django>=3.2,<4.0
wagtail: wagtail>=5.1,<5.2
- python: "3.9"
django: django>=4.1,<4.2
wagtail: wagtail>=4.1,<4.2
- python: "3.9"
django: django>=4.1,<4.2
wagtail: wagtail>=4.2,<5.0
- python: "3.9"
django: django>=4.1,<4.2
wagtail: wagtail>=5.0,<5.1
- python: "3.9"
django: django>=4.1,<4.2
wagtail: wagtail>=5.1,<5.2
- python: "3.10"
django: django>=3.2,<4.0
wagtail: wagtail>=4.1,<4.2
- python: "3.10"
django: django>=3.2,<4.0
wagtail: wagtail>=4.2,<5.0
- python: "3.10"
django: django>=3.2,<4.0
wagtail: wagtail>=5.0,<5.1
- python: "3.10"
django: django>=3.2,<4.0
wagtail: wagtail>=5.1,<5.2
- python: "3.10"
django: django>=4.1,<4.2
wagtail: wagtail>=4.1,<4.2
- python: "3.10"
django: django>=4.1,<4.2
wagtail: wagtail>=4.2,<5.0
- python: "3.10"
django: django>=4.1,<4.2
wagtail: wagtail>=5.0,<5.1
- python: "3.10"
django: django>=4.1,<4.2
wagtail: wagtail>=5.1,<5.2
- python: "3.11"
django: django>=4.1,<4.2
wagtail: wagtail>=4.1,<4.2
- python: "3.11"
django: django>=4.1,<4.2
wagtail: wagtail>=4.2,<5.0
- python: "3.11"
django: django>=4.1,<4.2
wagtail: wagtail>=5.0,<5.1
- python: "3.11"
django: django>=4.1,<4.2
wagtail: wagtail>=5.1,<5.2
- python: "3.11"
django: django>=4.2,<4.3
wagtail: wagtail>=5.0,<5.1
- python: "3.11"
django: django>=4.2,<4.3
wagtail: wagtail>=5.1,<5.2

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't want to add every possible permutation here because the original setup didn't do that and I thought there could be a reason for that. It might have been to have a reasonably quick testing time. For now I'll leave it alone but thanks @katdom13

@katdom13 katdom13 merged commit ea07fc3 into main Nov 17, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants