-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Python 3.6 support; add Python 3.10 support #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
d941195
to
760dad6
Compare
8733716
to
533d679
Compare
c2b418e
to
8923605
Compare
thibaudcolas
commented
Dec 21, 2021
toxenv: py39-dj22,py39-dj30,py39-dj31,py39-dj32,py39-djmain | ||
toxenv: py39-dj22,py39-dj30,py39-dj31,py39-dj32 | ||
- python: "3.10" | ||
toxenv: py310-dj32,py310-djmain |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two things worth mentioning here:
- I thought it would be enough to only test
djmain
with the most recent Python version - Similarly since
py31-dj32
is already tested in the previoustest
job, I’ve removed it here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This updates our test suite and the project’s metadata. Python 3.6’s support ends in 3 days. Python 3.10 has been out for a few months now and we need this package to support it.
The main difficulty here was getting Poetry to cooperate – they had a lot of Python 3.10 compatibility issues, and the
JSONDecodeError
fix from the latest v1.1.12 was required.Checklist
Suggested CHANGELOG entry: