Wagtail 5 support #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jams2
commented
Oct 17, 2023
Comment on lines
+7
to
+9
| html_template='wagtail_content_import/confirm_dialog.html', | ||
| js_template=None, | ||
| template_vars={}, |
There was a problem hiding this comment.
Unrelated change, just improves readability.
- Drop Python 3.7 from the matrix as it's unsupported - Drop Django 4.0 from the matrix as it's unsupported - Rename master to main (in line with Wagtail upstream)
jams2
force-pushed
the
wagtail-5-support
branch
from
3c715b6
to
7fb12c1
Compare
zerolab
requested changes
Oct 19, 2023
tox.ini
Outdated
| python{3.8,3.9,3.10}-django{3.2}-wagtail{4.1,4.2,master}-{sqlite,postgres} | ||
| python{3.8,3.9,3.10}-django{4.0,4.1}-wagtail{4.1,4.2,master}-{sqlite,postgres} | ||
| python{3.11}-django{4.1}-wagtail{4.1,4.2,master}-{sqlite,postgres} | ||
| python{3.8,3.9,3.10}-django3.2-wagtail{4.1,4.2,5.0,5.1,main}-{sqlite,postgres} |
There was a problem hiding this comment.
Suggestion: drop Wagtail 4.2 as it has EOLed - https://endoflife.date/wagtail. This will simplify the matrix considerably
There was a problem hiding this comment.
Thanks, reshuffled this a bit in f45bfef, it's a little easier on the eyes/brain.
tox.ini
Outdated
Comment on lines
35
to
36
| django4.0: Django>=4.0,<4.1 | ||
| django4.1: Django>=4.1,<4.2 |
There was a problem hiding this comment.
Suggested change
| django4.0: Django>=4.0,<4.1 | |
| django4.1: Django>=4.1,<4.2 | |
| django4.1: Django>=4.1,<4.2 | |
| django4.2: Django>=4.2,<5.0 |
There was a problem hiding this comment.
Nitpick - the commit message says 4.1 (which isn't EOL yet as it's an LTS release), although it is indeed removing 4.2.
gasman
approved these changes
Nov 2, 2023
jams2
force-pushed
the
wagtail-5-support
branch
from
f45bfef
to
bfdd6f3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have tested importing documents via:
I have tested constructing StructBlocks using custom converter classes.