Complete Wagtail 6.0 / Django 5.0 support #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laymonage
reviewed
Apr 2, 2024
There was a problem hiding this comment.
I didn't test any functionality other than the UI, but dropping the last commit in favour of the latest version of wagtail/wagtail#11751 seems to work fine (the previous fix had a few issues as mentioned in that PR). I'll merge that PR and see about releasing 6.0.2 sometime this week. Once 6.0.2 is out I think it's fair to drop the hack and advise people to use 6.0.2 or greater for 6.0.x support.
gasman
force-pushed
the
feature/wagtail-6-support
branch
from
c5910f1
to
05e8d96
Compare
|
CSS hack now reverted - confirmed that it works well against Wagtail 6.0.2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on #63 - additionally drops support for Wagtail <5.2 and Django <4.2, rewrites action buttons to use the
wagtail.admin.action_menumodule / templates rather than hard-coding pre-Wagtail-6 HTML, and incorporates wagtail/wagtail#11751 to restore usable styling ofextra_footer_actions.