Ignore ENOPROTOOPT errors from SO_REUSEADDR or SO_ERROR #2353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some systems, for example Hurd doesn't support SO_REUSEADDR.
bdarnell
reviewed
Apr 13, 2018
| if reuse_port: | ||
| sock.setsockopt(socket.SOL_SOCKET, socket.SO_REUSEPORT, 1) | ||
| try: | ||
| sock.setsockopt(socket.SOL_SOCKET, socket.SO_REUSEPORT, 1) |
There was a problem hiding this comment.
I don't think we should swallow the error for SO_REUSEPORT. This only happens if explicitly requested by the user, so if we can't do what they asked for we should raise the error.
| try: | ||
| err = self.socket.getsockopt(socket.SOL_SOCKET, socket.SO_ERROR) | ||
| except socket.error as e: | ||
| err = e.args[0] |
There was a problem hiding this comment.
Use errno_from_exception instead of e.args[0] everywhere.
bdarnell
added a commit
to bdarnell/tornado
that referenced
this pull request
May 19, 2018
- Don't swallow errors from SO_REUSEPORT since it's opt-in. - Use errno_from_exception. - Add comments
|
I'm taking over this change in #2392. |
bdarnell
added a commit
to bdarnell/tornado
that referenced
this pull request
Nov 1, 2019
- Don't swallow errors from SO_REUSEPORT since it's opt-in. - Use errno_from_exception.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some systems, for example Hurd doesn't support SO_REUSEADDR.