Updates for Python 3.12 #3288
Merged
Updates for Python 3.12 #3288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that python/cpython#105808 is fixed in beta 3.
Python 3.12 deprecates the utcnow and utcfromtimestamp methods and discourages the use of naive datetimes to represent UTC. This was previously the main way that Tornado used datetimes (since it was the only option available in Python 2 before the introduction of datetime.timezone.utc in Python 3.2). - httpclient_test: Test-only change to test that both kinds of datetimes are supported in If-Modified-Since (this just calls httputil.format_timestamp) - httputil: No functional changes, but format_timestamp's support for both naive and aware datetimes is now tested. - locale: format_timestamp now supports aware datetimes (in addition to the existing support for naive datetimes). - web: Cookie expirations internally use aware datetimes. StaticFileHandler.get_modified_time now supports both and the standard implementation returns aware. It feels fragile that "naive" and "aware" datetimes are not distinct types but subject to data-dependent behavior. This change uses "aware" datetimes throughout Tornado, but some operations (comparisons and subtraction) fail with mixed datetime types and if I missed any in this change may cause errors if naive datetimes were used (where previously naive datetimes would have been required). But that's apparently the API we have to work with.
|
Thank you! |
This was referenced Oct 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that the gzip bug (python/cpython#105808) is fixed in 3.12b3, we can bring that version back to CI. We also need to pick up a newer version of tox and make some changes to datetime handling to avoid deprecation warnings.
Fixes #3278
Closes #3277