Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates for Python 3.12 #3288

Merged
merged 3 commits into from
Jun 22, 2023
Merged

Updates for Python 3.12 #3288

merged 3 commits into from
Jun 22, 2023

Commits on Jun 22, 2023

  1. ci: Re-enable python 3.12 

    Now that python/cpython#105808 is fixed in beta 3.
    @bdarnell
    bdarnell committed Jun 22, 2023
    Configuration menu
    Copy the full SHA
    acde88d View commit details
    Browse the repository at this point in the history

  2. build: Upgrade tox to support python 3.12

    @bdarnell
    bdarnell committed Jun 22, 2023
    Configuration menu
    Copy the full SHA
    4c6b8ca View commit details
    Browse the repository at this point in the history

  3. *: Adapt to deprecation of datetime utc methods 

    Python 3.12 deprecates the utcnow and utcfromtimestamp methods and
discourages the use of naive datetimes to represent UTC. This was
previously the main way that Tornado used datetimes (since it was
the only option available in Python 2 before the introduction
of datetime.timezone.utc in Python 3.2).

- httpclient_test: Test-only change to test that both kinds of datetimes
  are supported in If-Modified-Since (this just calls
  httputil.format_timestamp)
- httputil: No functional changes, but format_timestamp's
  support for both naive and aware datetimes is now tested.
- locale: format_timestamp now supports aware datetimes (in
  addition to the existing support for naive datetimes).
- web: Cookie expirations internally use aware datetimes.
  StaticFileHandler.get_modified_time now supports both and the
  standard implementation returns aware.

It feels fragile that "naive" and "aware" datetimes are not distinct
types but subject to data-dependent behavior. This change uses
"aware" datetimes throughout Tornado, but some operations (comparisons
and subtraction) fail with mixed datetime types and if I missed any
in this change may cause errors if naive datetimes were used (where
previously naive datetimes would have been required). But that's
apparently the API we have to work with.
    @bdarnell
    bdarnell committed Jun 22, 2023
    Configuration menu
    Copy the full SHA
    4d4d80c View commit details
    Browse the repository at this point in the history