httpserver: If no X-Scheme header, use the normal request value. #695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, if xheaders is True and there are no X headers passed (e.g. when developing locally), scheme was always "http". This makes in "http" or "https", based on what was actually used for the request. Add tests for the X-Scheme and X-Forwarded-Proto headers.
bdarnell
added a commit
that referenced
this pull request
Mar 13, 2013
httpserver: If no X-Scheme header, use the normal request value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We ran into this problem when testing OAuth redirects on local development servers. In production, we use a reverse proxy. In testing, we use a local development server. It was always generating a redirect to http://localhost instead of https://localhost because of this issue.
Commit message:
Previously, if xheaders is True and there are no X headers passed (e.g. when
developing locally), scheme was always "http". This makes in "http" or
"https", based on what was actually used for the request.
Add tests for the X-Scheme and X-Forwarded-Proto headers.