Pumping MACOSX_DEPLOYMENT_TARGET #353
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pumps MACOSX_DEPLOYMENT_TARGET to 10.9. Xcode 10 on macOS 10.14 warns of libstdc++ deperation with the current target (10.7); the warning can be fixed by pumping the target version. The last release of Mac OS X 10.7 is 6 years old and according to [StatCounter](http://gs.statcounter.com/os-version-market-share/macos/desktop/worldwide), OS X 10.9 and later makes up for more than 95% of all mac OS machine online. Per OpenMathLib/OpenBLAS#1580, 10.9 should be a good minimal release target.
|
What do we gain by this except from the removal of the warning? |
|
At some point in the future, mac OS will no longer ship with libstdc++. Switching would allow future compatibility with minimal impact of current user. libc++ also, among other things, has a more performant standard library hashmap implementations. |
|
The MACOSX_DEPLOYMENT_TARGET has been raised to 10.9 in commit da41397 to avoid some problems when building the vsearch bioconda recipe. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pumps MACOSX_DEPLOYMENT_TARGET to 10.9. Xcode 10 on macOS 10.14 warns of libstdc++ deperation with the current target (10.7); the warning can be fixed by pumping the target version.
The last release of Mac OS X 10.7 is 6 years old and according to StatCounter, OS X 10.9 and later makes up for more than 95% of all mac OS machine online. Per OpenMathLib/OpenBLAS#1580, 10.9 should be a good minimal release target.