-
Notifications
You must be signed in to change notification settings - Fork 763
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new approach for builder pattern #15
Open
miladvafaeifard
wants to merge
2
commits into
torokmark:main
Choose a base branch
from
miladvafaeifard:builder-design-pattern-improvement
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,69 +1,104 @@ | ||
namespace BuilderPattern { | ||
export class UserBuilder { | ||
private name: string; | ||
private age: number; | ||
private phone: string; | ||
private address: string; | ||
|
||
constructor(name: string) { | ||
this.name = name; | ||
} | ||
|
||
get Name() { | ||
return this.name; | ||
} | ||
setAge(value: number): UserBuilder { | ||
this.age = value; | ||
return this; | ||
} | ||
get Age() { | ||
return this.age; | ||
} | ||
setPhone(value: string): UserBuilder { | ||
this.phone = value; | ||
return this; | ||
} | ||
get Phone() { | ||
return this.phone; | ||
} | ||
setAddress(value: string): UserBuilder { | ||
this.address = value; | ||
return this; | ||
} | ||
get Address() { | ||
return this.address; | ||
} | ||
|
||
build(): User { | ||
return new User(this); | ||
} | ||
} | ||
|
||
export class User { | ||
private name: string; | ||
private age: number; | ||
private phone: string; | ||
private address: string; | ||
|
||
constructor(builder: UserBuilder) { | ||
this.name = builder.Name; | ||
this.age = builder.Age; | ||
this.phone = builder.Phone; | ||
this.address = builder.Address | ||
} | ||
|
||
get Name() { | ||
return this.name; | ||
} | ||
get Age() { | ||
return this.age; | ||
} | ||
get Phone() { | ||
return this.phone; | ||
} | ||
get Address() { | ||
return this.address; | ||
} | ||
export interface Builder<T> { | ||
build(): T; | ||
} | ||
|
||
export class User { | ||
private name: string; | ||
private age: number; | ||
private phone: string; | ||
private address: string; | ||
|
||
constructor(builder: UserBuilder) { | ||
this.name = builder.Name; | ||
this.age = builder.Age; | ||
this.phone = builder.Phone; | ||
this.address = builder.Address; | ||
} | ||
|
||
get Name() { | ||
return this.name; | ||
} | ||
get Age() { | ||
return this.age; | ||
} | ||
get Phone() { | ||
return this.phone; | ||
} | ||
get Address() { | ||
return this.address; | ||
} | ||
} | ||
|
||
export interface Director<T> { | ||
create(): T; | ||
} | ||
|
||
export class UserBuilder implements Builder<User> { | ||
private name: string; | ||
private age: number; | ||
private phone: string; | ||
private address: string; | ||
|
||
constructor(name: string) { | ||
this.name = name; | ||
} | ||
|
||
setAge(value: number): UserBuilder { | ||
this.age = value; | ||
return this; | ||
} | ||
|
||
setPhone(value: string): UserBuilder { | ||
this.phone = value; | ||
return this; | ||
} | ||
|
||
setAddress(value: string): UserBuilder { | ||
this.address = value; | ||
return this; | ||
} | ||
|
||
getUser() { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. As I see, |
||
return this; | ||
} | ||
|
||
build(): User { | ||
return new User(this); | ||
} | ||
|
||
get Name() { | ||
return this.name; | ||
} | ||
|
||
get Age() { | ||
return this.age; | ||
} | ||
|
||
get Phone() { | ||
return this.phone; | ||
} | ||
|
||
get Address() { | ||
return this.address; | ||
} | ||
} | ||
|
||
export class UserDirector implements Director<User> { | ||
constructor(private userBuilder: UserBuilder) {} | ||
|
||
create() { | ||
if (this.userBuilder.Name === 'Jancsi') { | ||
this.userBuilder.setAge(12) | ||
.setPhone('0123456789') | ||
.setAddress('asdf'); | ||
} else { | ||
this.userBuilder.setAge(0) | ||
.setPhone('xxxxxxxxx') | ||
.setAddress('xxxx'); | ||
} | ||
|
||
return this.userBuilder.build(); | ||
} | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is a bit misleading to have getter by declaring with
get
and setters following Java POJO.Here, methods should be introduced with
set
keyword.