Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

26225 test get microdescriptors #3

Closed
wants to merge 4 commits into from
Closed

26225 test get microdescriptors #3

wants to merge 4 commits into from

Conversation

dmr-x
Copy link
Contributor

@dmr-x dmr-x commented Jun 22, 2018

@dmr-x
Typo fix as pointed out by Roger
0fde46e
@dmr-x
Fix additional typo
908f6e4
@dmr-x
Check the 'cached-microdescs' file for skipping, instead of 'cached-d…
80475d0 
…escriptors'

This should fix #26225, although attempts to reproduce were unfruitful,
so the fix hasn't been directly tested.

cefe584 (which introduced the check for
'cached-descriptors') had made this more stable, but since it was
checking a different file, it seems that some temporal edge cases could
still run this test into a failure, as evidenced by a few recent Jenkins
failures.
@dmr-x
Furthermore, decorate test_get_microdescriptors() with @test.require.…
6ddc67f 
…online

The previous commit should address #26225, but a tor instance that has
never been online won't generate a cache of microdescriptors, so it
seems superfluous (although not completely pointless) to run this test
outside the ONLINE target.
atagar added a commit that referenced this pull request Jun 25, 2018
@atagar
test_get_microdescriptors can be unreliable
7c3c6e5 
Pull request from Dave...

  https://trac.torproject.org/projects/tor/ticket/26225
  #3
@dmr-x
Copy link
Contributor Author

dmr-x commented Jul 16, 2018

GitHub doesn't have a way to mark PRs as "Rebased/merged", so this comment will have to do (for now, at least).
See: 7c3c6e5

1 similar comment
@dmr-x
Copy link
Contributor Author

dmr-x commented Jul 16, 2018

GitHub doesn't have a way to mark PRs as "Rebased/merged", so this comment will have to do (for now, at least).
See: 7c3c6e5

@dmr-x dmr-x closed this Jul 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dmr-x