Ticket31176 merged #1245
Merged
Ticket31176 merged #1245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'll want to make this block into a series of functions in a subsequent commit, but I'm doing this separately to get the indentation change out of the way. This branch will end up with making checkIncludes.py an integrated part of practracker, for ticket 31176.
We'll want this so that we can have each file evaluated independently, rather than a directory at a time.
Our topological sort code really deserves a function of its own. Additionally, don't print from inside the topological sort code: instead, return a result, and let the caller print it.
This is our shift from directory-at-a-time processing to file-at-a-time processing.
This makes checkIncludes match practracker more closely, and lets us eliminate a global.
Update the makefile accordingly.
Also add a temporary script to redirect the hook, if people don't upgrade for a bit.
A .may_includes file can be "advisory", which means that some violations of the rules are expected. We will track these violations with practracker, not as automatic errors.
We treat "0" as the expected number, and warn about everything else. The problem type is "dependency-violation".
Everything else assumes that somebody else will open the file for it.
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.