Reject 0.2.9 and 0.4.0 in dirserv_rejects_tor_version() #1586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 7431
💛 - Coveralls |
teor2345
reviewed
Dec 5, 2019
| // new enough to be supported | ||
| { "Tor 0.3.5.7", false }, | ||
| { "Tor 0.3.5.8", false }, | ||
| { "Tor 0.4.0.1-alpha", false }, | ||
| { "Tor 0.4.1.5", false }, |
There was a problem hiding this comment.
Please add test cases for the current releases 0.4.2 and 0.4.3.
teor2345
reviewed
Dec 5, 2019
src/feature/dirauth/process_descs.c
Outdated
| if (tor_version_as_new_as(platform,"0.3.0.0-alpha-dev") && | ||
| !tor_version_as_new_as(platform,"0.3.5.7")) { | ||
| /* Series between Tor 0.3.6 and 0.4.0 inclusive are unsupported. Reject | ||
| * them. */ |
There was a problem hiding this comment.
Let's document what actually happened to 0.3.6.
Suggested change
| * them. */ | |
| * them. 0.3.6.0-alpha-dev only existed for a short time, before it was renamed to 0.4.0.0-alpha-dev. */ |
teor2345
reviewed
Dec 5, 2019
src/feature/dirauth/process_descs.c
Outdated
| /* Series between Tor 0.3.6 and 0.4.0 inclusive are unsupported. Reject | ||
| * them. */ | ||
| if (tor_version_as_new_as(platform,"0.3.6.0-alpha-dev") && | ||
| !tor_version_as_new_as(platform,"0.4.1.1-alpha")) { |
There was a problem hiding this comment.
We should also decide if we want to reject 0.4.1 alphas and rcs.
ghost
closed this
ghost
deleted the branch
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.