Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ticket33617 #1872

Closed
wants to merge 3 commits into from
Closed

Conversation

Suraj-Upadhyay
Copy link
Contributor

Trac : https://trac.torproject.org/projects/tor/ticket/33617

Torrc Option: Add BandwidthStatistics
Write bandwidth statistics to disk.
Add BandwidthStatistics consensus parameter.

Some tests are to be added as per teor.

The functions added and modified are :-

  1. write_stats_file_callback()
  2. extrainfo_dump_to_string_stats_helper()
  3. bw_arrays_init() (Tests would be unnecessary).
  4. rep_hist_bw_stats_write()
  5. get_bandwidth_stats_param() (Tests Added).

Add a new torrc option, BandwidthStatistics.
Add config tests for the option.
Add manual entry for BandwidthStatistics.
Part of Ticket33617.
rephist.c  : Add a function to write bandwidth
	     statistics to disk.
mainloop.c : Consider option BandwidthStatistics
	     to write bandwidth stats to disk.
main.c	   : Add the new data directory info.
Manual	   : Update the manual for an additional
	     data directory.
Part of Ticket33617.
router.c  : Check BandwidthStatistics consensus
	    parameter before publishing stats in
	    extrainfo document.
rephist.c : Add function to check BandwidthStatistics
	    consensus parameter.
Test	  : Add tests for the above function, which
	    checks for the parameter.
Part of Ticket33617.
@coveralls
Copy link

Pull Request Test Coverage Report for Build 8799

  • 8 of 26 (30.77%) changed or added relevant lines in 4 files are covered.
  • 38 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.03%) to 64.142%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/app/main/main.c 0 2 0.0%
src/core/mainloop/mainloop.c 0 4 0.0%
src/feature/stats/rephist.c 6 18 33.33%
Files with Coverage Reduction New Missed Lines %
src/feature/dirauth/shared_random.c 1 85.71%
src/feature/relay/router.c 1 53.24%
src/feature/stats/rephist.c 36 46.15%
Totals Coverage Status
Change from base Build 8780: -0.03%
Covered Lines: 50849
Relevant Lines: 79276

💛 - Coveralls

@ghost ghost closed this May 25, 2021
@ghost ghost deleted the branch torproject:master May 25, 2021 12:57
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants