Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move unreachable port warnings to a periodic event. #70

Merged
merged 1 commit into from
May 3, 2018

Conversation

nmathewson
Copy link
Contributor

Arguably, the conditions under which these events happen should be a
bit different, but the rules are complex enough here that I've tried
to have this commit be pure refactoring.

Closes ticket 25952.

Finally, before this code goes away, take a moment to look at the
amazing way that we used to try to have an event happen
every N seconds:

  get_uptime() / N != (get_uptime()+seconds_elapsed) / N

Truly, it is a thing of wonder. I'm glad we didn't start using this
pattern everywhere else.

Arguably, the conditions under which these events happen should be a
bit different, but the rules are complex enough here that I've tried
to have this commit be pure refactoring.

Closes ticket 25952.

Finally, before this code goes away, take a moment to look at the
amazing way that we used to try to have an event happen
every N seconds:

      get_uptime() / N != (get_uptime()+seconds_elapsed) / N

Truly, it is a thing of wonder.  I'm glad we didn't start using this
pattern everywhere else.
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.004%) to 58.874% when pulling b396e4e on nmathewson:ticket25952 into 60a2c92 on torproject:master.

@tor-bot tor-bot merged commit b396e4e into torproject:master May 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants