-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Index API client: add timeout to requests #482
Merged
josecelano
merged 9 commits into
torrust:develop
from
josecelano:472-index-api-client-add-timeout-to-requests
Feb 9, 2024
Merged
Index API client: add timeout to requests #482
josecelano
merged 9 commits into
torrust:develop
from
josecelano:472-index-api-client-add-timeout-to-requests
Feb 9, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to the generic HTTP mod.
both in testing and production clients.
ef11cc4
to
26422fc
Compare
I think we can consume the forms, they are not likely to be used anymore.
The Index API Client user must handle request errors.
We should handle timeouts errors, that have been added to the API client.
ACK 47f5242 |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The API client does not have any timeout. The client waits indefinitely for responses. That should not be the default behaviour. It should return an error after a timeout. The users using the client should handle the timeout or any other error.
Subtasks
unwraps
from the generic HTTP client. Return errors.unwraps
from the Index API HTTP client. Return errors.