Configuration overhaul: replace primitive types in configuration with richer types #600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josecelano
force-pushed
the
599-configuration-overhaul-replace-primitive-types-in-configuration-with-richer-types
branch
from
be35927
to
fc5adf4
Compare
josecelano
force-pushed
the
599-configuration-overhaul-replace-primitive-types-in-configuration-with-richer-types
branch
from
23888cf
to
ddbab07
Compare
…database::Database
We will use the type `Mailbox` in the configuration and it needs to be serializable.
We were using a cusomt type but sqlx defines it as a URL. WE can validate this type in the configration and let the app domain validate if the connection URL is a valid one. For example, if the app supports the database driver. Otherwise we have to change this first level valitation anytime we support a new DB.
josecelano
force-pushed
the
599-configuration-overhaul-replace-primitive-types-in-configuration-with-richer-types
branch
from
d40311d
to
b1d5267
Compare
josecelano
force-pushed
the
599-configuration-overhaul-replace-primitive-types-in-configuration-with-richer-types
branch
from
7900f12
to
a95abfd
Compare
josecelano
force-pushed
the
599-configuration-overhaul-replace-primitive-types-in-configuration-with-richer-types
branch
from
a95abfd
to
8e53982
Compare
|
ACK ec1d39a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace primitive types in configuration with richer types.
Subtasks
torrust_index::config::v1::auth::Authtorrust_index::config::v1::database::Databasetorrust_index::config::v1::mail::Mailtorrust_index::config::v1::net::Networktorrust_index::config::v1::tracker::Trackertorrust_index::config::v1::Settings