Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config overhaul: make some fields mandatory #992

Conversation

josecelano
Copy link
Member

Some configuration options are mandatory. The tracker will panic if the user doesn't provide an explicit value for them from one of the configuration sources: TOML or ENV VARS.

The mandatory options are:

[metadata]
schema_version = "2.0.0"

[logging]
threshold = "info"

[core]
private = false
listed = false

@josecelano josecelano self-assigned this Aug 2, 2024
@josecelano josecelano added this to the v3.0.0 milestone Aug 2, 2024
@josecelano josecelano linked an issue Aug 2, 2024 that may be closed by this pull request
@josecelano josecelano force-pushed the 938-config-overhaul-make-some-fields-mandatory-remove-default-value branch from d167409 to 358c743 Compare August 2, 2024 10:57
@josecelano josecelano force-pushed the 938-config-overhaul-make-some-fields-mandatory-remove-default-value branch from 358c743 to 54d961c Compare August 2, 2024 13:54
@josecelano josecelano marked this pull request as ready for review August 2, 2024 13:57
@josecelano josecelano marked this pull request as draft August 2, 2024 14:32
Some configuration options are mandatory. The tracker will panic if the user doesn't provide an explicit value for them from one of the configuration sources: TOML or ENV VARS.

The mandatory options are:

```toml
[metadata]
schema_version = "2.0.0"

[logging]
threshold = "info"

[core]
private = false
listed = false
```
@josecelano josecelano force-pushed the 938-config-overhaul-make-some-fields-mandatory-remove-default-value branch from 54d961c to 90ef14d Compare August 2, 2024 15:05
@josecelano josecelano requested a review from da2ce7 August 2, 2024 15:05
@josecelano josecelano marked this pull request as ready for review August 2, 2024 15:31
@josecelano
Copy link
Member Author

ACK 90ef14d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Config overhaul: make some fields mandatory
1 participant