Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix incorrect use of pk_attr instead of db_pk_column when using RelationalField as the primary key #1362

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

tufbel
Copy link

@tufbel tufbel commented Mar 30, 2023

Description

When using RelationalField(pk=True) without specifying source_field, the value of meta.db_pk_column is the same as meta.pk_attr. Theoretically, the value of meta.db_pk_column should be f"{meta.db_pk_column}_id".
Fix the issue where the pk filter condition is not available when using RelationalField(pk=True).

Motivation and Context

I would like meta.db_pk_column to be recognized correctly when using RelationalField(pk=True).

How Has This Been Tested?

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added the changelog accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant