New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: bandit check error #1643

Merged

abondar merged 1 commit into tortoise:develop from waketzheng:fix-make-lint

Jun 12, 2024

Contributor

waketzheng commented Jun 11, 2024

Add exclude_dirs and nosec for bandit

Description

bandit check is no need to cover unittest code

Motivation and Context

fix make lint error

How Has This Been Tested?

make ci && make lint

Checklist:

My code follows the code style of this project.
My change requires a change to the documentation.
I have updated the documentation accordingly.
I have added the changelog accordingly.
I have read the CONTRIBUTING document.
I have added tests to cover my changes.
All new and existing tests passed.


          fix: bandit check error

73e9bb6

coveralls commented Jun 11, 2024 •

edited

Loading

Pull Request Test Coverage Report for Build 9461000468

Details

1 of 2 (50.0%) changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 87.844%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
tortoise/backends/oracle/executor.py	0	1	0.0%

Totals
Change from base Build 9345308446:	0.0%
Covered Lines:	5779
Relevant Lines:	6481

💛 - Coveralls

abondar approved these changes

View reviewed changes

abondar merged commit 3568b8f into tortoise:develop

7 checks passed

waketzheng deleted the fix-make-lint branch

June 13, 2024 16:18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet