Allow negative values with IntEnumField
#895
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@long2ice Looks like you may be the only active maintainer, and I see there's a lot of open PRs awaiting review and without any initial comment -- is there anything that can be done to help with reviews, or otherwise move things along? |
long2ice
approved these changes
Sep 6, 2021
Pull Request Test Coverage Report for Build 1208488420
💛 - Coveralls |
|
Thanks! Could you update changelog? |
This expands the range of accepted values for SmallIntField (and therefore IntEnumField) to include negative values down to -32768, which assumes the underlying SMALLINT column uses signed integers. Database-specific notes: * PostgreSQL only provides signed SMALLINT columns. * MySQL provides a signed SMALLINT column by default. * SQLite doesn't enforce a range on its only integer type.
Terrance
force-pushed
the
int-enum-negative
branch
from
a5cc5fe
to
7dfbd82
Compare
long2ice
approved these changes
Sep 7, 2021
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This permits negative values for a non-generated
IntEnumField.Motivation and Context
Fixes #889.
How Has This Been Tested?
Tests updated to check the new minimum both for generated and non-generated fields.
Checklist:
(there are 4 existing test failures from develop)