Skip to content

Commit

Permalink
cifs: Fix sparse warning when calling cifs_strtoUCS
Browse files Browse the repository at this point in the history
Fix sparse endian check warning while calling cifs_strtoUCS

CHECK   fs/cifs/smbencrypt.c
fs/cifs/smbencrypt.c:216:37: warning: incorrect type in argument 1
(different base types)
fs/cifs/smbencrypt.c:216:37:    expected restricted __le16 [usertype] *<noident>
fs/cifs/smbencrypt.c:216:37:    got unsigned short *<noident>

Signed-off-by: Steve French <smfrench@gmail.com>
Acked-by: Shirish Pargaonkar <shirishpargaonkar@gmail.com
  • Loading branch information
Steve French authored and smfrench committed Dec 9, 2011
1 parent 9a5101c commit 59edb63
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions fs/cifs/smbencrypt.c
Original file line number Diff line number Diff line change
Expand Up @@ -209,7 +209,7 @@ E_md4hash(const unsigned char *passwd, unsigned char *p16,
{
int rc;
int len;
__u16 wpwd[129];
__le16 wpwd[129];

/* Password cannot be longer than 128 characters */
if (passwd) /* Password must be converted to NT unicode */
Expand All @@ -219,8 +219,8 @@ E_md4hash(const unsigned char *passwd, unsigned char *p16,
*wpwd = 0; /* Ensure string is null terminated */
}

rc = mdfour(p16, (unsigned char *) wpwd, len * sizeof(__u16));
memset(wpwd, 0, 129 * sizeof(__u16));
rc = mdfour(p16, (unsigned char *) wpwd, len * sizeof(__le16));
memset(wpwd, 0, 129 * sizeof(__le16));

return rc;
}
Expand Down

0 comments on commit 59edb63

Please sign in to comment.