Browse files

iucv: Fix missing msg_namelen update in iucv_sock_recvmsg()

The current code does not fill the msg_name member in case it is set.
It also does not set the msg_namelen member to 0 and therefore makes
net/socket.c leak the local, uninitialized sockaddr_storage variable
to userland -- 128 bytes of kernel stack memory.

Fix that by simply setting msg_namelen to 0 as obviously nobody cared
about iucv_sock_recvmsg() not filling the msg_name in case it was set.

Cc: Ursula Braun <>
Signed-off-by: Mathias Krause <>
Signed-off-by: David S. Miller <>
  • Loading branch information...
1 parent 5ae94c0 commit a5598bd9c087dc0efc250a5221e5d0e6f584ee88 @minipli minipli committed with davem330 Apr 7, 2013
Showing with 2 additions and 0 deletions.
  1. +2 −0 net/iucv/af_iucv.c
2 net/iucv/af_iucv.c
@@ -1328,6 +1328,8 @@ static int iucv_sock_recvmsg(struct kiocb *iocb, struct socket *sock,
struct sk_buff *skb, *rskb, *cskb;
int err = 0;
+ msg->msg_namelen = 0;
if ((sk->sk_state == IUCV_DISCONN) &&
skb_queue_empty(&iucv->backlog_skb_q) &&
skb_queue_empty(&sk->sk_receive_queue) &&

0 comments on commit a5598bd

Please sign in to comment.