Skip to content

Commit a5598bd

Browse files
miniplidavem330
authored andcommitted
iucv: Fix missing msg_namelen update in iucv_sock_recvmsg()
The current code does not fill the msg_name member in case it is set. It also does not set the msg_namelen member to 0 and therefore makes net/socket.c leak the local, uninitialized sockaddr_storage variable to userland -- 128 bytes of kernel stack memory. Fix that by simply setting msg_namelen to 0 as obviously nobody cared about iucv_sock_recvmsg() not filling the msg_name in case it was set. Cc: Ursula Braun <ursula.braun@de.ibm.com> Signed-off-by: Mathias Krause <minipli@googlemail.com> Signed-off-by: David S. Miller <davem@davemloft.net>
1 parent 5ae94c0 commit a5598bd

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

Diff for: net/iucv/af_iucv.c

+2
Original file line numberDiff line numberDiff line change
@@ -1328,6 +1328,8 @@ static int iucv_sock_recvmsg(struct kiocb *iocb, struct socket *sock,
13281328
struct sk_buff *skb, *rskb, *cskb;
13291329
int err = 0;
13301330

1331+
msg->msg_namelen = 0;
1332+
13311333
if ((sk->sk_state == IUCV_DISCONN) &&
13321334
skb_queue_empty(&iucv->backlog_skb_q) &&
13331335
skb_queue_empty(&sk->sk_receive_queue) &&

0 commit comments

Comments
 (0)