Skip to content
Browse files

ipv6: ip6_sk_dst_check() must not assume ipv6 dst

It's possible to use AF_INET6 sockets and to connect to an IPv4
destination. After this, socket dst cache is a pointer to a rtable,
not rt6_info.

ip6_sk_dst_check() should check the socket dst cache is IPv6, or else
various corruptions/crashes can happen.

Dave Jones can reproduce immediate crash with
trinity -q -l off -n -c sendmsg -c connect

With help from Hannes Frederic Sowa

Reported-by: Dave Jones <>
Reported-by: Hannes Frederic Sowa <>
Signed-off-by: Eric Dumazet <>
Acked-by: Hannes Frederic Sowa <>
Signed-off-by: David S. Miller <>
  • Loading branch information
Eric Dumazet authored and davem330 committed Jun 26, 2013
1 parent 5dbe7c1 commit a963a37d384d71ad43b3e9e79d68d42fbe0901f3
Showing with 7 additions and 1 deletion.
  1. +7 −1 net/ipv6/ip6_output.c
@@ -821,11 +821,17 @@ static struct dst_entry *ip6_sk_dst_check(struct sock *sk,
const struct flowi6 *fl6)
struct ipv6_pinfo *np = inet6_sk(sk);
struct rt6_info *rt = (struct rt6_info *)dst;
struct rt6_info *rt;

if (!dst)
goto out;

if (dst->ops->family != AF_INET6) {
return NULL;

rt = (struct rt6_info *)dst;
/* Yes, checking route validity in not connected
* case is not very simple. Take into account,
* that we do not support routing by source, TOS,

0 comments on commit a963a37

Please sign in to comment.
You can’t perform that action at this time.