Skip to content
Permalink
Browse files

Bluetooth: sco: fix information leak to userspace

struct sco_conninfo has one padding byte in the end.  Local variable
cinfo of type sco_conninfo is copied to userspace with this uninizialized
one byte, leading to old stack contents leak.

Signed-off-by: Vasiliy Kulikov <segoon@openwall.com>
Signed-off-by: Gustavo F. Padovan <padovan@profusion.mobi>
  • Loading branch information...
Vasiliy Kulikov Gustavo F. Padovan
Vasiliy Kulikov authored and Gustavo F. Padovan committed Feb 14, 2011
1 parent 43629f8 commit c4c896e1471aec3b004a693c689f60be3b17ac86
Showing with 1 addition and 0 deletions.
  1. +1 −0 net/bluetooth/sco.c
@@ -703,6 +703,7 @@ static int sco_sock_getsockopt_old(struct socket *sock, int optname, char __user
break;
}

memset(&cinfo, 0, sizeof(cinfo));
cinfo.hci_handle = sco_pi(sk)->conn->hcon->handle;
memcpy(cinfo.dev_class, sco_pi(sk)->conn->hcon->dev_class, 3);

0 comments on commit c4c896e

Please sign in to comment.
You can’t perform that action at this time.