Permalink
Browse files

HID: hid-example: fix some build issues

samples/hid-example.o needs some Kconfig and Makefile additions in order
to build.  It should use <linux/*.h> headers from the build tree, so use
HEADERS_CHECK to require that those header files be present.

Change the kconfig symbol from tristate to bool since userspace cannot be
built as loadable modules.

However, I don't understand why the userspace header files are not present
as reported in Andrew's build log, since it builds OK on x86_64 without
any of these changes.

Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
Cc: Alan Ott <alan@signal11.us>
Cc: Jiri Kosina <jkosina@suse.cz>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
  • Loading branch information...
1 parent cb3e85f commit d431b2e33cd54e4334019a95979ae93aea4735e8 Randy Dunlap committed with Jiri Kosina Apr 21, 2011
Showing with 4 additions and 2 deletions.
  1. +2 −2 samples/Kconfig
  2. +2 −0 samples/hidraw/Makefile
View
@@ -62,8 +62,8 @@ config SAMPLE_KDB
command to the kdb shell.
config SAMPLE_HIDRAW
- tristate "Build simple hidraw example"
- depends on HIDRAW
+ bool "Build simple hidraw example"
+ depends on HIDRAW && HEADERS_CHECK
help
Build an example of how to use hidraw from userspace.
@@ -6,3 +6,5 @@ hostprogs-y := hid-example
# Tell kbuild to always build the programs
always := $(hostprogs-y)
+
+HOSTCFLAGS_hid-example.o += -I$(objtree)/usr/include

0 comments on commit d431b2e

Please sign in to comment.