Skip to content

Commit

Permalink
ide: missing break statement in set_timings_mdma()
Browse files Browse the repository at this point in the history
There was clearly supposed to be a break statement here.  Currently we
use the k2 ata timings instead of sh ata ones we intended.  Probably no
one has this hardware anymore so it likely doesn't make a difference
beyond the static checker warning.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Dan Carpenter authored and davem330 committed Jul 26, 2016
1 parent 45969e1 commit d4f8c2e
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions drivers/ide/pmac.c
Original file line number Diff line number Diff line change
Expand Up @@ -707,6 +707,7 @@ set_timings_mdma(ide_drive_t *drive, int intf_type, u32 *timings, u32 *timings2,
*timings = ((*timings) & ~TR_133_PIOREG_MDMA_MASK) | tr;
*timings2 = (*timings2) & ~TR_133_UDMAREG_UDMA_EN;
}
break;
case controller_un_ata6:
case controller_k2_ata6: {
/* 100Mhz cell */
Expand Down

0 comments on commit d4f8c2e

Please sign in to comment.