Skip to content

Commit da2311a

Browse files
Xiaolong Huangmarckleinebudde
Xiaolong Huang
authored andcommitted
can: kvaser_usb: kvaser_usb_leaf: Fix some info-leaks to USB devices
Uninitialized Kernel memory can leak to USB devices. Fix this by using kzalloc() instead of kmalloc(). Signed-off-by: Xiaolong Huang <butterflyhuangxx@gmail.com> Fixes: 7259124 ("can: kvaser_usb: Split driver into kvaser_usb_core.c and kvaser_usb_leaf.c") Cc: linux-stable <stable@vger.kernel.org> # >= v4.19 Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
1 parent 2de4973 commit da2311a

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

Diff for: drivers/net/can/usb/kvaser_usb/kvaser_usb_leaf.c

+3-3
Original file line numberDiff line numberDiff line change
@@ -608,7 +608,7 @@ static int kvaser_usb_leaf_simple_cmd_async(struct kvaser_usb_net_priv *priv,
608608
struct kvaser_cmd *cmd;
609609
int err;
610610

611-
cmd = kmalloc(sizeof(*cmd), GFP_ATOMIC);
611+
cmd = kzalloc(sizeof(*cmd), GFP_ATOMIC);
612612
if (!cmd)
613613
return -ENOMEM;
614614

@@ -1140,7 +1140,7 @@ static int kvaser_usb_leaf_set_opt_mode(const struct kvaser_usb_net_priv *priv)
11401140
struct kvaser_cmd *cmd;
11411141
int rc;
11421142

1143-
cmd = kmalloc(sizeof(*cmd), GFP_KERNEL);
1143+
cmd = kzalloc(sizeof(*cmd), GFP_KERNEL);
11441144
if (!cmd)
11451145
return -ENOMEM;
11461146

@@ -1206,7 +1206,7 @@ static int kvaser_usb_leaf_flush_queue(struct kvaser_usb_net_priv *priv)
12061206
struct kvaser_cmd *cmd;
12071207
int rc;
12081208

1209-
cmd = kmalloc(sizeof(*cmd), GFP_KERNEL);
1209+
cmd = kzalloc(sizeof(*cmd), GFP_KERNEL);
12101210
if (!cmd)
12111211
return -ENOMEM;
12121212

0 commit comments

Comments
 (0)