fix(d1): put back missing serial-trace feature
#278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Looks like the feature flag was lost in #271, so the D1 binaries no longer emit traceproto output. I believe this happened when combining the `mnemos-d1` crate (which used to enable the feature) with the `mnemos-d1-core` crate (which didn't enable the feature). This commit puts it back. :)
hawkw
commented
Sep 16, 2023
| @@ -130,30 +130,33 @@ fmt: | |||
| {{ _cargo }} fmt --package {{ _mn_pkg }} | |||
|
|
|||
| # build a Mnemos binary for the Allwinner D1 | |||
| build-d1 board='mq-pro': (_get-cargo-command "objcopy" "cargo-binutils") | |||
| build-d1 board='mq-pro' *CARGO_ARGS='': (_get-cargo-command "objcopy" "cargo-binutils") | |||
There was a problem hiding this comment.
at some point we may just want to start turning these just recipes into proper cargo xtasks with mn, so that we can pass more complex CLI args to them...but i didn't want to do that as part of this change.
hawkw
added a commit
that referenced
this pull request
Sep 16, 2023
Depends on #278. This commit makes a very small change to how the crowtty traceproto output formats an event's `message` field. The message is now printed first, and (when the terminal supports ANSI formatting escapes), it's bolded, so that it stands out a bit from other fields and metadata. Also, I've changed `crowtty` so that the message field is always printed first, rather than ordering it alphabetically by field name. This should improve the consistency of log lines and hopefully make them a bit easier to read. For example: 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like the feature flag was lost in #271, so the D1 binaries no
longer emit traceproto output. I believe this happened when combining
the
mnemos-d1crate (which used to enable the feature) with themnemos-d1-corecrate (which didn't enable the feature).This commit puts it back. :)
I've also modified the Just recipes for building D1 images to allow
passing additional args to Cargo. This way, users of the Just recipes
can now pass
--no-default-features --features ...to pick which featuresare enabled when building. This was necessary for testing what happened
when the board config had a
serial-tracesection but the feature flag wasdisabled. But, passing extra cargo args may also be useful in other
situations.