feat(crowtty): more readable tracing messages #279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit makes a very small change to how the crowtty traceproto output formats an event's `message` field. The message is now printed without the `message=` prefix, shortening the log line, and it's now bolded so the message stands out from the other fields and metadata. I think this is a little more readable.
hawkw
force-pushed
the
eliza/crowtty-prettify
branch
from
6ae3653
to
c03d11e
Compare
jamesmunns
approved these changes
Sep 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #278.
This commit makes a very small change to how the crowtty traceproto
output formats an event's
messagefield. The message is now printedfirst, and (when the terminal supports ANSI formatting escapes), it's
bolded, so that it stands out a bit from other fields and metadata.
Also, I've changed
crowttyso that the message field is always printedfirst, rather than ordering it alphabetically by field name. This should
improve the consistency of log lines and hopefully make them a bit
easier to read.
For example: