Stop twf.Spacer from injecting None key in validated data.

toscawidgets · May 24, 2012 · 71b33b5 · 71b33b5
1 parent 8218360
commit 71b33b5
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 0 deletions.
diff --git a/tests/test_widgets.py b/tests/test_widgets.py
@@ -494,6 +494,18 @@ class TestSpacer(WidgetTest):
     attrs = {}
     expected = """<div></div>"""
 
+
+def test_spacer_validation():
+    """ Test that spacers don't inject None keys in validated data. """
+
+    class SomeForm(TableForm):
+        some_id = HiddenField
+        space = Spacer
+
+    data = SomeForm.validate({})
+    assert None not in data
+
+
 class TestLabel(WidgetTest):
     widget = Label
     attrs = {'text':'something'}

diff --git a/tw2/forms/widgets.py b/tw2/forms/widgets.py
@@ -614,6 +614,9 @@ class Spacer(FormField):
     id = None
     label = None
 
+    def _validate(self, value, state=None):
+        return twc.EmptyField
+
 
 class Label(twc.Widget):
     """