Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Fixed the Gemfile to work on Windows (+ other general changes) #1113

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 5 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 13 additions & 6 deletions Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,9 @@ gem 'activeadmin'
gem 'devise'
gem 'figaro'
gem 'jbuilder', '~> 2.0'
gem 'pg', '~> 0.21'
gem 'puma', '>= 3.12.4'
gem 'pg', '~> 0.21' if RUBY_PLATFORM !~ /mingw32/
gem 'pg', '~> 1.4' if RUBY_PLATFORM =~ /mingw32/
gem "puma", ">= 3.12.4"
gem 'rails', '~> 5.2.5'
gem 'redis'

Expand Down Expand Up @@ -45,7 +46,7 @@ gem 'httparty'
# for api pagination
gem 'kaminari'

gem 'mini_racer'
gem 'mini_racer' if RUBY_PLATFORM !~ /mingw32/ # Too many problems, is it even needed?

group :development do
gem 'letter_opener'
Expand All @@ -66,7 +67,7 @@ group :development, :test do
gem 'rack-mini-profiler'
gem 'spring'
gem 'spring-watcher-listen', '~> 2.0.0'
gem 'stackprof'
gem 'stackprof' if RUBY_PLATFORM !~ /mingw32/ # Not supported on Microsoft Windows
gem 'database_cleaner-active_record'
gem 'factory_bot_rails'
gem 'faker'
Expand All @@ -78,10 +79,16 @@ group :development, :test do
gem 'capybara'
end

gem 'sentry-ruby'
gem 'sentry-rails'
gem "sentry-ruby"
gem "sentry-rails"
gem 'grape', '~> 1.7'
gem 'grape-entity'
gem 'grape_on_rails_routes'
gem 'rack-cors'
gem 'uuidtools', '~> 2.1', '>= 2.1.5'

# For Windows only
gem 'sys-proctable' if RUBY_PLATFORM =~ /mingw32/
gem 'fast_stack' if RUBY_PLATFORM =~ /mingw32/
gem 'wdm', '>= 0.1.0' if Gem.win_platform?
gem 'tzinfo-data' if RUBY_PLATFORM =~ /mingw32/
madoleary marked this conversation as resolved.
Show resolved Hide resolved
6 changes: 5 additions & 1 deletion QUICKSTART.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@ macOS run `sh INSTALL_mac.sh`.

## Manual environment setup

If you are using Microsoft Windows, download Ruby [here](https://github.com/oneclick/rubyinstaller2/releases/download/RubyInstaller-2.7.2-1/rubyinstaller-devkit-2.7.2-1-x64.exe).

### Install Ruby with [Rbenv](https://github.com/rbenv/rbenv)

(shamelessly copied from Rbenv doc)
Expand Down Expand Up @@ -82,7 +84,9 @@ Install Rails, Postgres, Yarn, etc
echo "deb https://dl.yarnpkg.com/debian/ stable main" | sudo tee /etc/apt/sources.list.d/yarn.list
sudo apt update && sudo apt install yarn

In your code directory run:
If you are using Windows, install node.js [here](https://nodejs.org/dist/v18.16.0/node-v18.16.0-x64.msi) (comes with Yarn) and PostgreSQL [here](https://sbp.enterprisedb.com/getfile.jsp?fileid=1258422). Install Ruby on Rails by running `gem install rails` on the command line.

In your code directory run (if you are using Windows, do not run the `rbenv` commands):

git clone https://github.com/tosdr/edit.tosdr.org
cd edit.tosdr.org
Expand Down
Loading