Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Fixed the Gemfile to work on Windows (+ other general changes) #1113

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

EarldridgeJazzedPineda
Copy link

@EarldridgeJazzedPineda EarldridgeJazzedPineda commented Apr 27, 2023

  • Are you working on the latest release?
  • Have you tested it locally?
  • Please explain your change
  • I have opened a Jira Issue for this Pull Request
  • My Squashed Commit Message Contains the Issue Key e.g Feature: EDIT-12 Added XXX
    Thanks !

Version 1.2.13
This version contains fixes for the Gemfile, in order the make Phoenix work on Microsoft Windows.

  • The version for the gem 'pg' has been upgraded to 1.4.
  • Due to some problems compiling the gem 'mini_racer', the Gemfile is modified so that it does not compile on Windows. I am not even sure if that gem is needed anyway.
  • Because 'stackprof' is not officially supported on Windows, the Gemfile is modified so that it will not be installed on Windows.
  • Added 4 new gems: 'sys-proctable', 'fast_stack', 'wdm' (for Windows Only), and 'tzinfo-data'.

@EarldridgeJazzedPineda
Copy link
Author

@JustinBack PLEASE HELP ME NOW
image

@JustinBack
Copy link
Member

Thats correct, Jira is for internal ToS;DR use only. However I've created an issue for it

https://tosdr.atlassian.net/browse/EDIT-95

Will test the PR and if all goes well, merge it :-)

Added information for Microsoft Windows
@EarldridgeJazzedPineda EarldridgeJazzedPineda changed the title Fixed the Gemfile to work on Windows (+ other general changes) [fix] Fixed the Gemfile to work on Windows (+ other general changes) May 1, 2023
@EarldridgeJazzedPineda
Copy link
Author

OK now?

@EarldridgeJazzedPineda
Copy link
Author

Justin, is it okay to merge now?

@JustinBack
Copy link
Member

We are still discussing internally things related to the dependencies.

@JustinBack
Copy link
Member

I've had talks with @madoleary and we noticed that adding those dependencies breaks our Gitpod Integration, the CI seems to fail and running it in a linux environment fails.

Especially the dependencies are a huge problem in this PR as we cannot really test the breaking change from pg 0.21 to 1.4, as well as adding a lot of dependencies on all OS just to run the dev environment on windows

+ gem 'sys-proctable'
+ gem 'fast_stack'
+ gem 'tzinfo-data'

We feel like making certain local modifications when trying to spin up an open source project in dev env is just kind of the way it is when working on open source stuff.

You are free to use Gitpod (as its free for a generous amount of time) and spins up a cloud-based ready-to-code instance of Phoenix
Open in Gitpod
if you like to contribute to ToS;DR.

Though we like your changes to the quickstart and would like to merge those!

If you'd like to, you can contribute a INSTALL_windows.bat to accommodate the changes to the windows machine.

Once we've migrated to Ruby 3, the compability might be better with Windows, so don't take this as a "we would never support Windows" :-)

@EarldridgeJazzedPineda
Copy link
Author

Okay, I will try to fix those

Removing unnecessary changes
@EarldridgeJazzedPineda
Copy link
Author

OK now?

@EarldridgeJazzedPineda
Copy link
Author

Okay?

Gemfile Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants