hasClass() on an empty set should return false

tosh · Aug 24, 2010 · 64bc66a · 64bc66a
1 parent c4ef1de
commit 64bc66a
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 2 deletions.
diff --git a/spec/tests/core-tests.js b/spec/tests/core-tests.js
@@ -173,6 +173,13 @@ CoreTests.prototype.run = function () {
         test( 'should return false when element does not have the specified class', function(){
             equals(x.hasClass('zug'), false, 'Element with id "has-class-element" should not have the class "zug"');
         });
+
+		test('should return false when the selector matches zero elements', function () {
+			var y = x$('#this-should-never-exist-in-the-dom');
+			equals(y.length, 0);
+			equals(y.hasClass('bar'), false);
+		});
+
     // --
     /// dom specs
     // --

diff --git a/src/IE/core/style.js b/src/IE/core/style.js
@@ -150,7 +150,7 @@ xui.extend({
     hasClass: function(className, callback) {
         return (callback === undefined && this.length == 1) ?
             hasClass(this[0], className) :
-            this.each(function(el) {
+            this.length && this.each(function(el) {
                 if (hasClass(el, className)) {
                     callback(el);
                 }

diff --git a/src/core/style.js b/src/core/style.js
@@ -150,7 +150,7 @@ xui.extend({
     hasClass: function(className, callback) {
         return (callback === undefined && this.length == 1) ?
             hasClass(this[0], className) :
-            this.each(function(el) {
+            this.length && this.each(function(el) {
                 if (hasClass(el, className)) {
                     callback(el);
                 }