test(react-image): add test code for `SuspenseImage` #999

saul-atomrigs · 2024-06-28T02:09:29Z

Overview

Added test code for SuspenseImage.tsx in react-image.

Captura de pantalla 2024-06-28 a las 10 39 23 a  m

PR Checklist

[✅] I did below actions if need

I read the Contributing Guide
I added documents and tests.

changeset-bot · 2024-06-28T02:09:33Z

🦋 Changeset detected

Latest commit: 40f0a91

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@suspensive/react-image	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

vercel · 2024-06-28T02:09:34Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
suspensive.org	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jun 28, 2024 5:03am
v1.suspensive.org	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jun 28, 2024 5:03am
visualization.suspensive.org	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jun 28, 2024 5:03am

manudeli

How about this

manudeli · 2024-06-28T02:11:45Z

packages/react-image/src/SuspenseImage.spec.tsx

+      // @ts-expect-error: non-string src value for testing purposes
+      render(<SuspenseImage src={123} alt="Test Image" />)
+    }).toThrow('Image of @suspensive/react-image requires src')


Suggested change

// @ts-expect-error: non-string src value for testing purposes

render(<SuspenseImage src={123} alt="Test Image" />)

}).toThrow('Image of @suspensive/react-image requires src')

// @ts-expect-error: non-string src value for testing purposes

render(<SuspenseImage src={123} alt="Test Image" />)

}).toThrow('<SuspenseImage/> of @suspensive/react-image requires string src')

Looks great! I've applied the change to SuspenseImage and its test file :))

codecov-commenter · 2024-06-28T02:50:23Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.33%. Comparing base (8e7e260) to head (40f0a91).

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #999      +/-   ##
==========================================
+ Coverage   80.88%   87.33%   +6.44%     
==========================================
  Files          38       38              
  Lines         450      450              
  Branches       98       98              
==========================================
+ Hits          364      393      +29     
+ Misses         77       54      -23     
+ Partials        9        3       -6

Components	Coverage Δ
@suspensive/react	`97.03% <ø> (ø)`
@suspensive/react-query	`∅ <ø> (∅)`
@suspensive/react-query-4	`0.00% <ø> (ø)`
@suspensive/react-query-5	`0.00% <ø> (ø)`
@suspensive/react-await	`100.00% <ø> (ø)`
@suspensive/react-image	`80.39% <100.00%> (+56.86%)`	⬆️

codspeed-hq · 2024-06-28T02:50:27Z

CodSpeed Performance Report

Merging #999 will create unknown performance changes

_{Comparing saul-atomrigs:test/react-image/SuspenseImage (40f0a91) with main (8e7e260)}

Summary

⚠️ No benchmarks were detected in both the base of the PR and the PR.

…aul-atomrigs/suspensive into test/react-image/SuspenseImage

manudeli

Cool! Thanks! 👍

packages/react-image/src/SuspenseImage.spec.tsx

@saul-atomrigs

This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @suspensive/react-image@0.0.15 ### Patch Changes - [#999](#999) [`8862c2a`](8862c2a) Thanks [@saul-atomrigs](https://github.com/saul-atomrigs)! - test(react-image): add test code for `<SuspenseImage/>` Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Overview - Added test code for `SuspenseImage.tsx` in `react-image`. <img width="373" alt="Captura de pantalla 2024-06-28 a las 10 39 23 a  m" src="https://github.com/toss/suspensive/assets/82362278/eea53c08-dc45-4ac3-a62f-59b2aa70ae24"> ## PR Checklist - [✅] I did below actions if need 1. I read the [Contributing Guide](https://github.com/toss/suspensive/blob/main/CONTRIBUTING.md) 2. I added documents and tests. --------- Co-authored-by: Jonghyeon Ko <jonghyeon@toss.im>

@saul-atomrigs

This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @suspensive/react-image@0.0.15 ### Patch Changes - [#999](#999) [`8862c2a`](8862c2a) Thanks [@saul-atomrigs](https://github.com/saul-atomrigs)! - test(react-image): add test code for `<SuspenseImage/>` Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Overview - Added test code for `SuspenseImage.tsx` in `react-image`. <img width="373" alt="Captura de pantalla 2024-06-28 a las 10 39 23 a  m" src="https://github.com/toss/suspensive/assets/82362278/eea53c08-dc45-4ac3-a62f-59b2aa70ae24"> ## PR Checklist - [✅] I did below actions if need 1. I read the [Contributing Guide](https://github.com/toss/suspensive/blob/main/CONTRIBUTING.md) 2. I added documents and tests. ---------

@saul-atomrigs

This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @suspensive/react-image@0.0.15 ### Patch Changes - [#999](#999) [`8862c2a`](8862c2a) Thanks [@saul-atomrigs](https://github.com/saul-atomrigs)! - test(react-image): add test code for `<SuspenseImage/>`

# Overview - Added test code for `SuspenseImage.tsx` in `react-image`. <img width="373" alt="Captura de pantalla 2024-06-28 a las 10 39 23 a  m" src="https://github.com/toss/suspensive/assets/82362278/eea53c08-dc45-4ac3-a62f-59b2aa70ae24"> ## PR Checklist - [✅] I did below actions if need 1. I read the [Contributing Guide](https://github.com/toss/suspensive/blob/main/CONTRIBUTING.md) 2. I added documents and tests. --------- Co-authored-by: Jonghyeon Ko <jonghyeon@toss.im>

@saul-atomrigs

This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @suspensive/react-image@0.0.15 ### Patch Changes - [#999](#999) [`8862c2a`](8862c2a) Thanks [@saul-atomrigs](https://github.com/saul-atomrigs)! - test(react-image): add test code for `<SuspenseImage/>`

# Overview - Added test code for `SuspenseImage.tsx` in `react-image`. <img width="373" alt="Captura de pantalla 2024-06-28 a las 10 39 23 a  m" src="https://github.com/toss/suspensive/assets/82362278/eea53c08-dc45-4ac3-a62f-59b2aa70ae24"> ## PR Checklist - [✅] I did below actions if need 1. I read the [Contributing Guide](https://github.com/toss/suspensive/blob/main/CONTRIBUTING.md) 2. I added documents and tests. --------- Co-authored-by: Jonghyeon Ko <jonghyeon@toss.im>

@saul-atomrigs

This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @suspensive/react-image@0.0.15 ### Patch Changes - [#999](#999) [`8862c2a`](8862c2a) Thanks [@saul-atomrigs](https://github.com/saul-atomrigs)! - test(react-image): add test code for `<SuspenseImage/>`

test(react-image): add test code for suspenseimage

e780ff2

saul-atomrigs requested review from manudeli, okinawaa and minsoo-web as code owners June 28, 2024 02:09

github-actions bot added the @suspensive/react-image label Jun 28, 2024

vercel bot deployed to Preview – v1.suspensive.org June 28, 2024 02:10 View deployment

vercel bot deployed to Preview – visualization.suspensive.org June 28, 2024 02:11 View deployment

vercel bot deployed to Preview – suspensive.org June 28, 2024 02:11 View deployment

manudeli reviewed Jun 28, 2024

View reviewed changes

manudeli assigned saul-atomrigs Jun 28, 2024

Merge branch 'main' into test/react-image/SuspenseImage

f8ace79

vercel bot deployed to Preview – visualization.suspensive.org June 28, 2024 02:49 View deployment

vercel bot deployed to Preview – suspensive.org June 28, 2024 02:50 View deployment

vercel bot deployed to Preview – v1.suspensive.org June 28, 2024 02:50 View deployment

saul-atomrigs added 2 commits June 28, 2024 12:40

test(react-image): improve the error message

76bd4e3

Merge branch 'test/react-image/SuspenseImage' of https://github.com/s…

7f305d4

…aul-atomrigs/suspensive into test/react-image/SuspenseImage

vercel bot deployed to Preview – v1.suspensive.org June 28, 2024 03:48 View deployment

vercel bot deployed to Preview – visualization.suspensive.org June 28, 2024 03:49 View deployment

vercel bot deployed to Preview – suspensive.org June 28, 2024 03:49 View deployment

manudeli approved these changes Jun 28, 2024

View reviewed changes

Create curly-radios-breathe.md

5a650bd

vercel bot deployed to Preview – visualization.suspensive.org June 28, 2024 05:01 View deployment

vercel bot deployed to Preview – v1.suspensive.org June 28, 2024 05:01 View deployment

manudeli reviewed Jun 28, 2024

View reviewed changes

packages/react-image/src/SuspenseImage.spec.tsx Outdated Show resolved Hide resolved

Update packages/react-image/src/SuspenseImage.spec.tsx

40f0a91

vercel bot deployed to Preview – visualization.suspensive.org June 28, 2024 05:02 View deployment

vercel bot deployed to Preview – v1.suspensive.org June 28, 2024 05:03 View deployment

vercel bot deployed to Preview – suspensive.org June 28, 2024 05:03 View deployment

manudeli merged commit 8862c2a into toss:main Jun 28, 2024
14 checks passed

github-actions bot mentioned this pull request Jun 28, 2024

chore: version packages #1001

Merged

This pull request was closed.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test(react-image): add test code for `SuspenseImage` #999

test(react-image): add test code for `SuspenseImage` #999

saul-atomrigs commented Jun 28, 2024

changeset-bot bot commented Jun 28, 2024 •

edited

Loading

vercel bot commented Jun 28, 2024 •

edited

Loading

manudeli left a comment

manudeli Jun 28, 2024 •

edited

Loading

saul-atomrigs Jun 28, 2024

codecov-commenter commented Jun 28, 2024 •

edited

Loading

codspeed-hq bot commented Jun 28, 2024 •

edited

Loading

manudeli left a comment •

edited

Loading

test(react-image): add test code for SuspenseImage #999

test(react-image): add test code for SuspenseImage #999

Conversation

saul-atomrigs commented Jun 28, 2024

Overview

PR Checklist

changeset-bot bot commented Jun 28, 2024 • edited Loading

🦋 Changeset detected

vercel bot commented Jun 28, 2024 • edited Loading

manudeli left a comment

Choose a reason for hiding this comment

manudeli Jun 28, 2024 • edited Loading

Choose a reason for hiding this comment

saul-atomrigs Jun 28, 2024

Choose a reason for hiding this comment

codecov-commenter commented Jun 28, 2024 • edited Loading

Codecov Report

codspeed-hq bot commented Jun 28, 2024 • edited Loading

CodSpeed Performance Report

Merging #999 will create unknown performance changes

Summary

manudeli left a comment • edited Loading

Choose a reason for hiding this comment

test(react-image): add test code for `SuspenseImage` #999

test(react-image): add test code for `SuspenseImage` #999

changeset-bot bot commented Jun 28, 2024 •

edited

Loading

vercel bot commented Jun 28, 2024 •

edited

Loading

manudeli Jun 28, 2024 •

edited

Loading

codecov-commenter commented Jun 28, 2024 •

edited

Loading

codspeed-hq bot commented Jun 28, 2024 •

edited

Loading

manudeli left a comment •

edited

Loading