fix: fix completion for sh/bash/zsh #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
issue #43 reported compgen failing on completion parameters that looked like they were command line switches (e.g. "--") This looks to be due to incorrect usage of compgen, where the difference between options and the user's completion to complete were not separated with the "--" delimiter. According to getopt(1) documentation this should be split explicitly: When the end of options is encountered, the getopts utility shall exit with a return value greater than zero; the shell variable OPTIND shall be set to the index of the first operand, or the value "$#"+1 if there are no operands; the name variable shall be set to the <question-mark> character. Any of the following shall identify the end of options: the first "--" argument that is not an option-argument, finding an argument that is not an option- argument and does not begin with a '-', or encountering an error. This fixes the issue when reproing locally.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue #43 reported compgen failing on completion parameters that looked like they were command line switches (e.g. "--")
This looks to be due to incorrect usage of compgen, where the difference between options and the user's completion to complete were not separated with the "--" delimiter. According to getopt(1) documentation this should be split explicitly:
This fixes the issue when reproing locally.