@BugFix deleting versions did not honor key cleaning.

toumorokoshi · Dec 21, 2016 · 6b9927f · 6b9927f
1 parent 8c09037
commit 6b9927f
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 2 deletions.
diff --git a/tests/packages/test_versions.py b/tests/packages/test_versions.py
@@ -33,3 +33,13 @@ def test_versions_coerce_lowercase_get(versions):
         "SQLAlchemy": "==1.0.11"
     })
     assert versions["SQLAlchemy"] == "==1.0.11"
+
+
+def test_delete_coerce_lowercase(versions):
+    """
+    getting a package name should also be lowercase.
+    """
+    versions.update({
+        "SQLAlchemy": "==1.0.11"
+    })
+    del versions["SQLAlchemy"]
diff --git a/uranium/packages/versions.py b/uranium/packages/versions.py
@@ -8,18 +8,23 @@ def __init__(self):
         self._values = {}
 
     def __setitem__(self, key, value):
-        key = str(key).lower()
+        key = self._clean_key(key)
         self._values[key] = value
 
     def __getitem__(self, key):
-        key = str(key).lower()
+        key = self._clean_key(key)
         return self._values[key]
 
     def __delitem__(self, key):
+        key = self._clean_key(key)
         del self._values[key]
 
     def __iter__(self):
         return iter(self._values)
 
     def __len__(self):
         return len(self._values)
+
+    @staticmethod
+    def _clean_key(key):
+        return str(key).lower()