command_endpoints: sanitize result #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stintel
force-pushed
the
feature/endpoint_response_strip_newlines
branch
from
dfac24a
to
636652d
Compare
A command endpoint that inserts newlines in the speech result causes the result to be printed outside of the display. We do not want to deal with this in the Willow C code, and as we will eventually make WAS command mode the default and rip out endpoint support from Willow, we can simply do this in WAS. As we're using a pydantic model for the command endpoint result, we can easily do this with a sanitize function in the CommandEndpointResult model, and call this when we initialize the CommandEndpointResponse. We can't do it when we initialize the CommandEndpointResult, as we sometimes change the speech attribute after init.
stintel
force-pushed
the
feature/endpoint_response_strip_newlines
branch
from
636652d
to
c0d5e73
Compare
|
This is great! I've noticed this most with LLM support. I added (more or less) the exact same code to WAC but this is a much better approach! |
kristiankielhofner
deleted the
feature/endpoint_response_strip_newlines
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A command endpoint that inserts newlines in the speech result causes the result to be printed outside of the display. We do not want to deal with this in the Willow C code, and as we will eventually make WAS command mode the default and rip out endpoint support from Willow, we can simply do this in WAS.
As we're using a pydantic model for the command endpoint result, we can easily do this with a sanitize function in the CommandEndpointResult model, and call this when we initialize the CommandEndpointResponse. We can't do it when we initialize the CommandEndpointResult, as we sometimes change the speech attribute after init.