-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refresh tower-http #8
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looking good 👍
@@ -1,16 +1,5 @@ | |||
[package] | |||
name = "tower-http" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this broke the tower-grpc
build - that project still contains references to this package.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep... I messed that up. Fixes are coming.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The recent churn is an effort to get the whole thing on crates.io :) so sorry about that.
/// See [`lift`] function documentation for more details. | ||
/// | ||
/// [`lift`]: # | ||
pub struct LiftService<T> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some downstream services like @LucioFranco 's tower-consul breaks with lift service being removed, lift should just be replaced with straight service impls correct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lift just got renamed to AsService
so just need to change the functions we call in tower-consul
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is more to it than that, LiftService only has T, where AsService is AsService<'a, T>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LiftService
->IntoService
LiftServiceRef
->AsService
.
It should have just been a rename. If not, I messed up.
This is a work in progress to bring
tower-http
up to date.