Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refresh tower-http #8

Merged
merged 9 commits into from
Mar 4, 2019
Merged

Refresh tower-http #8

merged 9 commits into from
Mar 4, 2019

Conversation

carllerche
Copy link
Member

This is a work in progress to bring tower-http up to date.

Copy link
Member

@LucioFranco LucioFranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good 👍

tower-http-service/src/lib.rs Outdated Show resolved Hide resolved
tower-http-service/src/util/as_service.rs Outdated Show resolved Hide resolved
@carllerche carllerche marked this pull request as ready for review March 4, 2019 19:51
@carllerche carllerche merged commit 64585dd into tower-rs:master Mar 4, 2019
@@ -1,16 +1,5 @@
[package]
name = "tower-http"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this broke the tower-grpc build - that project still contains references to this package.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep... I messed that up. Fixes are coming.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The recent churn is an effort to get the whole thing on crates.io :) so sorry about that.

/// See [`lift`] function documentation for more details.
///
/// [`lift`]: #
pub struct LiftService<T> {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some downstream services like @LucioFranco 's tower-consul breaks with lift service being removed, lift should just be replaced with straight service impls correct?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lift just got renamed to AsService so just need to change the functions we call in tower-consul

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is more to it than that, LiftService only has T, where AsService is AsService<'a, T>

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • LiftService -> IntoService
  • LiftServiceRef -> AsService.

It should have just been a rename. If not, I messed up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants