Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix off-by-one error in promote_to_ready #41

Merged
merged 1 commit into from
Jan 26, 2018
Merged

Conversation

hawkw
Copy link
Member

@hawkw hawkw commented Jan 26, 2018

The .. syntax creates a half-open range (see https://doc.rust-lang.org/std/ops/struct.Range.html), so all that messing about with n-1 in #39 and #40 was never actually necessary. This actually fixes the Conduit test I mentioned in #39 (comment); it no longer hangs.

Signed-off-by: Eliza Weisman eliza@buoyant.io

Signed-off-by: Eliza Weisman <eliza@buoyant.io>
@hawkw hawkw added the C-bug Category: This is a bug. label Jan 26, 2018
@hawkw hawkw self-assigned this Jan 26, 2018
@hawkw hawkw requested a review from olix0r January 26, 2018 00:51
@hawkw
Copy link
Member Author

hawkw commented Jan 26, 2018

I left in the trace logging that I used to fix this, since I think it'll continue to be useful to actually know what's happening inside the loop.

@hawkw hawkw merged commit c132a99 into master Jan 26, 2018
@carllerche carllerche deleted the eliza/fix-promote-to-ready branch February 19, 2018 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: This is a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants