Fix potential integer overflow in Balance #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An usize overflow can occur in `Balance::promote_to_ready` when `self.not_ready` has length 0. See my comment here: #39 (comment) Signed-off-by: Eliza Weisman <eliza@buoyant.io>
carllerche
approved these changes
Jan 25, 2018
There was a problem hiding this comment.
Seems fine to me, but I would prefer if @olix0r could take a look as well.
olix0r
reviewed
Jan 25, 2018
tower-balance/src/lib.rs
Outdated
| @@ -151,7 +151,7 @@ where | |||
| debug!("promoting to ready: {}", n); | |||
| // Iterate through the not-ready endpoints from right to left to prevent removals | |||
| // from reordering services in a way that could prevent a service from being polled. | |||
| for idx in (0..n-1).rev() { | |||
There was a problem hiding this comment.
tioli: i think this would be slightly clearer as:
return Ok(());
}
for idx in (0..n-1).rev() {
...
}
it makes the intent a bit clearer...
There was a problem hiding this comment.
Sorry, I don't follow? This is the line that was removed.
olix0r
approved these changes
Jan 25, 2018
Signed-off-by: Eliza Weisman <eliza@buoyant.io>
hawkw
added a commit
that referenced
this pull request
Jan 26, 2018
The `..` syntax creates a _half-open_ range (see https://doc.rust-lang.org/std/ops/struct.Range.html), so all that messing about with `n-1` in #39 and #40 was never actually necessary. This actually fixes the Conduit test I mentioned in #39 (comment); it no longer hangs. Signed-off-by: Eliza Weisman <eliza@buoyant.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An usize overflow can occur in
Balance::promote_to_readywhenself.not_readyhas length 0.See my comment here: #39 (comment)
Signed-off-by: Eliza Weisman eliza@buoyant.io