Add layer_fn
#491
Merged
Add layer_fn
#491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #267
olix0r
reviewed
Dec 26, 2020
hawkw
reviewed
Dec 28, 2020
tower-layer/src/layer_fn.rs
Outdated
Comment on lines
3
to
4
| /// Returns a new `impl Layer` with the given closure. | ||
| pub fn layer_fn<F, S, T>(f: F) -> impl Layer<S, Service = T> + Clone |
There was a problem hiding this comment.
nit: could be nice to have an example here?
There was a problem hiding this comment.
Yes ofc. Added one in bbf93a7
hawkw
approved these changes
Dec 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #267
I went with
layer_fnoverlayer::from_fnbecause changingservice_fnwould be a breaking change. But I don't mind changing it if you think thats more appropriate 😊