New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add layer_fn
#491
Merged
Merged
Add layer_fn
#491
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
3ab3fd1
Add `layer_fn`
davidpdrsn d86e41e
Make `LayerFn` type private
davidpdrsn 07e5306
Revert "Make `LayerFn` type private"
davidpdrsn 6d96085
Give `LayerFn` a more useful `Debug` implementation
davidpdrsn bbf93a7
Add example usage of `layer_fn`
davidpdrsn 8574ca1
Apply docs suggestions from code review
hawkw File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,25 @@ | ||
use super::Layer; | ||
|
||
/// Returns a new `impl Layer` with the given closure. | ||
pub fn layer_fn<F, S, T>(f: F) -> impl Layer<S, Service = T> + Clone | ||
where | ||
F: Fn(S) -> T + Clone, | ||
{ | ||
LayerFn { f } | ||
} | ||
|
||
#[derive(Clone, Copy, Debug)] | ||
hawkw marked this conversation as resolved.
Show resolved
Hide resolved
|
||
struct LayerFn<F> { | ||
f: F, | ||
} | ||
|
||
impl<F, S, T> Layer<S> for LayerFn<F> | ||
where | ||
F: Fn(S) -> T, | ||
{ | ||
type Service = T; | ||
|
||
fn layer(&self, inner: S) -> Self::Service { | ||
(self.f)(inner) | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: could be nice to have an example here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes ofc. Added one in bbf93a7