New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tox should not silently ignore multiple -e options #109

Closed
pytoxbot opened this Issue Sep 17, 2016 · 4 comments

Comments

Projects
None yet
1 participant
@pytoxbot

pytoxbot commented Sep 17, 2016

When you invoke "tox -e py26 --notest" and want to rerun taht py27, one would expect
that just adding " -e py27" at the end of the previous command would work.
But that silently ingores "-e py26" and you have to do "tox -e py26,py27 --notest" (which to me is not a natural commandline invocation YMMV)

Tox should not silently ignore all but the last "-e" option and:

  • give out a warning on the correct combination syntax
  • add the -e options together.

The three ways of handling this (silent, warning, add together) could be set in $HOME/.tox/tox.ini, if backwards compatibility is required with silently ignoring as default.

@pytoxbot

This comment has been minimized.

Show comment
Hide comment
@pytoxbot

pytoxbot Sep 17, 2016

Original comment by @hpk42

fix issue109 and fix issue111: multiple "-e" options are now combined
(previously the last one would win). Thanks Anthon van der Neut.

→ <<cset 3be5bca16f8b>>

pytoxbot commented Sep 17, 2016

Original comment by @hpk42

fix issue109 and fix issue111: multiple "-e" options are now combined
(previously the last one would win). Thanks Anthon van der Neut.

→ <<cset 3be5bca16f8b>>

@pytoxbot

This comment has been minimized.

Show comment
Hide comment
@pytoxbot

pytoxbot Sep 17, 2016

Original comment by @hpk42

dash_e: fixes #109 and #111

Behaviour of -e has not changed, but can be set by passing True or False
as a parameter multi_dash_e to tox/_config.py: prepare_parse()

This parameter should come from a user specifyable default value
for backwards compatibility. Default should preferable be True after
that is implemented.

_split_env() was factored out of class parseini to enable testing

The issue #111: error on specifying same env twice ("tox -e py27,py27")
fixed. Multiple specifications of the same environment result in
multiple invocation (this could also be selectable in a
configuration file)

→ <>

pytoxbot commented Sep 17, 2016

Original comment by @hpk42

dash_e: fixes #109 and #111

Behaviour of -e has not changed, but can be set by passing True or False
as a parameter multi_dash_e to tox/_config.py: prepare_parse()

This parameter should come from a user specifyable default value
for backwards compatibility. Default should preferable be True after
that is implemented.

_split_env() was factored out of class parseini to enable testing

The issue #111: error on specifying same env twice ("tox -e py27,py27")
fixed. Multiple specifications of the same environment result in
multiple invocation (this could also be selectable in a
configuration file)

→ <>

@pytoxbot

This comment has been minimized.

Show comment
Hide comment
@pytoxbot

pytoxbot Sep 17, 2016

Original comment by @hpk42

dash_e: fixes #109 and #111

Behaviour of -e has not changed, but can be set by passing True or False
as a parameter multi_dash_e to tox/_config.py: prepare_parse()

This parameter should come from a user specifyable default value
for backwards compatibility. Default should preferable be True after
that is implemented.

_split_env() was factored out of class parseini to enable testing

The issue #111: error on specifying same env twice ("tox -e py27,py27")
fixed. Multiple specifications of the same environment result in
multiple invocation (this could also be selectable in a
configuration file)

→ <<cset 96e1ba41e1c0>>

pytoxbot commented Sep 17, 2016

Original comment by @hpk42

dash_e: fixes #109 and #111

Behaviour of -e has not changed, but can be set by passing True or False
as a parameter multi_dash_e to tox/_config.py: prepare_parse()

This parameter should come from a user specifyable default value
for backwards compatibility. Default should preferable be True after
that is implemented.

_split_env() was factored out of class parseini to enable testing

The issue #111: error on specifying same env twice ("tox -e py27,py27")
fixed. Multiple specifications of the same environment result in
multiple invocation (this could also be selectable in a
configuration file)

→ <<cset 96e1ba41e1c0>>

@pytoxbot

This comment has been minimized.

Show comment
Hide comment
@pytoxbot

pytoxbot Sep 17, 2016

Original comment by @hpk42

dash_e: fixes #109 and #111

Behaviour of -e has not changed, but can be set by passing True or False
as a parameter multi_dash_e to tox/_config.py: prepare_parse()

This parameter should come from a user specifyable default value
for backwards compatibility. Default should preferable be True after
that is implemented.

_split_env() was factored out of class parseini to enable testing

The issue #111: error on specifying same env twice ("tox -e py27,py27")
fixed. Multiple specifications of the same environment result in
multiple invocation (this could also be selectable in a
configuration file)

→ <>

pytoxbot commented Sep 17, 2016

Original comment by @hpk42

dash_e: fixes #109 and #111

Behaviour of -e has not changed, but can be set by passing True or False
as a parameter multi_dash_e to tox/_config.py: prepare_parse()

This parameter should come from a user specifyable default value
for backwards compatibility. Default should preferable be True after
that is implemented.

_split_env() was factored out of class parseini to enable testing

The issue #111: error on specifying same env twice ("tox -e py27,py27")
fixed. Multiple specifications of the same environment result in
multiple invocation (this could also be selectable in a
configuration file)

→ <>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment