-eALL should also include environment from envlist #1155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goneri
force-pushed
the
include_ALL
branch
6 times, most recently
from
60c505f
to
66ba126
Compare
According to the `--help` output, `-eALL` should work against specified
environments (ALL selects all). However, the environments from the
envlist key were ignored if they were not associated with a section.
For instance, with:
```
[tox]
envlist = py{a,b}
```
No environment was selected, and the default `python` was used instead.
With this patch, `tox` with test both `a` and `b`.
gaborbernat
approved these changes
Feb 5, 2019
|
|
|
Thanks for the quick review 👍 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the
--helpoutput,-eALLshould work against specifiedenvironments (ALL selects all). However, the environments from the
envlist key were ignored if they were not associated with a section.
For instance, with:
No environment was selected, and the default
pythonwas used instead.With this patch,
toxwith test bothaandb.