Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the failing CI on master #1456

Merged
merged 2 commits into from
Nov 13, 2019
Merged

fix the failing CI on master #1456

merged 2 commits into from
Nov 13, 2019

Conversation

gaborbernat
Copy link
Member

@gaborbernat gaborbernat commented Nov 11, 2019

The PR also bumps the linter tool versions, and drop python3.4 as the CI no longer supports it.

Copy link
Contributor

@asottile asottile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Signed-off-by: Bernat Gabor <bgabor8@bloomberg.net>
@todo
Copy link

todo bot commented Nov 13, 2019

process numbers work differently on pypy")

@pytest.mark.skipif(INFO.IS_PYPY, reason="TODO: process numbers work differently on pypy")
@pytest.mark.skipif(
"sys.platform == 'win32'", reason="triggering SIGINT reliably on Windows is hard"
)


This comment was generated by todo based on a TODO comment in 38fe5fc in #1456. cc @gaborbernat.

@todo
Copy link

todo bot commented Nov 13, 2019

process numbers work differently on pypy")

@pytest.mark.skipif(INFO.IS_PYPY, reason="TODO: process numbers work differently on pypy")
@pytest.mark.skipif(
"sys.platform == 'win32'", reason="triggering SIGINT reliably on Windows is hard"
)


This comment was generated by todo based on a TODO comment in 38fe5fc in #1456. cc @gaborbernat.

Signed-off-by: Bernat Gabor <bgabor8@bloomberg.net>
@todo
Copy link

todo bot commented Nov 13, 2019

process numbers work differently on pypy")

@pytest.mark.skipif(INFO.IS_PYPY, reason="TODO: process numbers work differently on pypy")
@pytest.mark.skipif(
"sys.platform == 'win32'", reason="triggering SIGINT reliably on Windows is hard"
)


This comment was generated by todo based on a TODO comment in 0bc8aad in #1456. cc @gaborbernat.

@todo
Copy link

todo bot commented Nov 13, 2019

process numbers work differently on pypy")

@pytest.mark.skipif(INFO.IS_PYPY, reason="TODO: process numbers work differently on pypy")
@pytest.mark.skipif(
"sys.platform == 'win32'", reason="triggering SIGINT reliably on Windows is hard"
)


This comment was generated by todo based on a TODO comment in 0bc8aad in #1456. cc @gaborbernat.

@gaborbernat
Copy link
Member Author

That was long but succeeded 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants