refactor session #1145

gaborbernat · 2019-01-20T19:25:22Z

While looking into doing #998 I realized the concept of env logs and actions have been heavily overlooked, furthermore the reporting should not be tied to the session (as we should report before the session object is constructed). This PR tries to fix all this and split up the longer and longer getting session.py.

obestwalter · 2019-01-21T12:20:47Z

Wow, that's a big one :)

Would you like feedback already about the direction this goes in? I'll have some time tomorrow afternoon to have closer look, if it makes sense already.

gaborbernat · 2019-01-21T12:27:42Z

@obestwalter yeah hence opening it 👍 even though not 100% ready yet.

asottile

I didn't get a chance to read through it all -- got about halfway through and realized github probably doesn't show moves well so I'll probably need to look using the cli

Overall the parts I looked at seemed fine, moving the reporter to a global seems risky, especially now that we;re doing parallel things

src/tox/_pytestplugin.py

asottile · 2019-01-21T15:15:20Z

src/tox/_pytestplugin.py



 @pytest.fixture
 def newmocksession(mocksession, newconfig):
    def newmocksession_(args, source, plugins=()):
-        mocksession.config = newconfig(args, source, plugins=plugins)
+        config = newconfig(args, source, plugins=plugins)
+        mocksession.__init__(config)


interesting, I've never seen this before -- I assume it just re-initializes the object? is this well defined?

It's just a function call AFAIK 👍

seems well defined but ill-advised

I don't quite get, why this change is necessary at all.

because we want to reset the report, calculated session venvs when a new config is loaded 👍 can use the _reset path though.

src/tox/_pytestplugin.py

src/tox/action.py

src/tox/config/__init__.py

src/tox/helper/build_isolated.py

src/tox/package/__init__.py

src/tox/package/local.py

src/tox/reporter.py

src/tox/session/__init__.py

obestwalter · 2019-01-22T22:35:14Z

I only had time to skim through, but I like the general direction of it. I'll try to carve out some more time tomorrow to play with it.

obestwalter · 2019-01-25T14:01:17Z

I'd say let's run with this after the comments are addressed and test failures are fixed.

Stripping down the several __init__.py modules to what really hast to be there can be also done in a later PR.

Main thing is we keep backwards compatibility regarding the main objects that people use from other tools / plugins.

gaborbernat · 2019-02-05T18:20:16Z

This looks OK for now. I'm not 100% settled on the reporting thing, but we can take it for a test drive. Maybe instead we should just use the logging framework which we kinda mimic. But this can be a subsequent PR to migrate to that.

cjerdonek · 2019-03-28T05:42:07Z

It looks like this PR causes pip's CI to fail. Here is the traceback:

  File "/home/travis/virtualenv/python3.6.7/bin/tox", line 11, in <module>
    sys.exit(cmdline())
  File "/home/travis/virtualenv/python3.6.7/lib/python3.6/site-packages/tox/session/__init__.py", line 42, in cmdline
    main(args)
  File "/home/travis/virtualenv/python3.6.7/lib/python3.6/site-packages/tox/session/__init__.py", line 63, in main
    retcode = session.runcommand()
  File "/home/travis/virtualenv/python3.6.7/lib/python3.6/site-packages/tox/session/__init__.py", line 187, in runcommand
    return self.subcommand_test()
  File "/home/travis/virtualenv/python3.6.7/lib/python3.6/site-packages/tox/session/__init__.py", line 215, in subcommand_test
    run_sequential(self.config, self.venv_dict)
  File "/home/travis/virtualenv/python3.6.7/lib/python3.6/site-packages/tox/session/commands/run/sequential.py", line 9, in run_sequential
    if venv.setupenv():
  File "/home/travis/virtualenv/python3.6.7/lib/python3.6/site-packages/tox/venv.py", line 582, in setupenv
    status = self.update(action=action)
  File "/home/travis/virtualenv/python3.6.7/lib/python3.6/site-packages/tox/venv.py", line 240, in update
    self.hook.tox_testenv_create(action=action, venv=self)
  File "/home/travis/virtualenv/python3.6.7/lib/python3.6/site-packages/pluggy/hooks.py", line 284, in __call__
    return self._hookexec(self, self.get_hookimpls(), kwargs)
  File "/home/travis/virtualenv/python3.6.7/lib/python3.6/site-packages/pluggy/manager.py", line 67, in _hookexec
    return self._inner_hookexec(hook, methods, kwargs)
  File "/home/travis/virtualenv/python3.6.7/lib/python3.6/site-packages/pluggy/manager.py", line 61, in <lambda>
    firstresult=hook.spec.opts.get("firstresult") if hook.spec else False,
  File "/home/travis/virtualenv/python3.6.7/lib/python3.6/site-packages/pluggy/callers.py", line 208, in _multicall
    return outcome.get_result()
  File "/home/travis/virtualenv/python3.6.7/lib/python3.6/site-packages/pluggy/callers.py", line 80, in get_result
    raise ex[1].with_traceback(ex[2])
  File "/home/travis/virtualenv/python3.6.7/lib/python3.6/site-packages/pluggy/callers.py", line 187, in _multicall
    res = hook_impl.function(*args)
  File "/home/travis/virtualenv/python3.6.7/lib/python3.6/site-packages/tox_venv/hooks.py", line 99, in tox_testenv_create
    venv.session.make_emptydir(venv.path)
AttributeError: 'VirtualEnv' object has no attribute 'session'

Apparently this is because tox-venv relies on the VirtualEnv object's session attribute, which this PR removes: https://github.com/tox-dev/tox-venv/blob/31b874292ed3da5fee701d2a048db4c8b1ad8cae/src/tox_venv/hooks.py#L99

cjerdonek · 2019-03-28T05:48:25Z

Also, tox-venv's setup.py says:

install_requires=['tox>=2.0'],

gaborbernat force-pushed the provision branch 2 times, most recently from e656e49 to f9391fc Compare January 20, 2019 19:28

gaborbernat requested review from obestwalter and asottile and removed request for obestwalter January 21, 2019 09:30

gaborbernat force-pushed the provision branch 2 times, most recently from 8bae2e4 to bbc2c11 Compare January 21, 2019 13:11

asottile reviewed Jan 21, 2019

View reviewed changes

gaborbernat mentioned this pull request Jan 22, 2019

get capfd of run in fixture pytest-dev/pytest#4663

Closed

gaborbernat mentioned this pull request Jan 25, 2019

Buffer parallel output to prevent interleaving #1143

Closed

gaborbernat and others added 12 commits February 5, 2019 07:39

start rebuild

e62bf8b

more test fixes

8b68a18

more test fixes

bb65a44

ignore pip wheel metadata

7c756b9

avoid calling __init__ outside of constructor

426c8af

use True over 1 in while

bab8d26

fix windows issues

4a83815

fix more

bfac373

more fix

053ae63

more fix

acdcdc9

fix python 2 on Windows

060e694

use capfd

cb627e5

gaborbernat force-pushed the provision branch from 7c8ac3b to cb627e5 Compare February 5, 2019 07:39

gaborbernat changed the title ~~[WIP] Refactor session~~ refactor session Feb 5, 2019

gaborbernat merged commit 984ce02 into tox-dev:master Feb 5, 2019

gaborbernat deleted the provision branch February 5, 2019 18:20

adamantike mentioned this pull request Feb 12, 2019

[parallel] .tox/log already exists #1137

Closed

konstin mentioned this pull request Jun 21, 2019

TypeError: Item in ``from list'' must be str, not NoneType #1344

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor session #1145

refactor session #1145

gaborbernat commented Jan 20, 2019

obestwalter commented Jan 21, 2019

gaborbernat commented Jan 21, 2019 •

edited

Loading

asottile left a comment

asottile Jan 21, 2019

gaborbernat Jan 21, 2019

asottile Jan 21, 2019

obestwalter Jan 22, 2019

gaborbernat Jan 25, 2019

obestwalter commented Jan 22, 2019

obestwalter commented Jan 25, 2019

gaborbernat commented Feb 5, 2019

cjerdonek commented Mar 28, 2019 •

edited

Loading

cjerdonek commented Mar 28, 2019

refactor session #1145

refactor session #1145

Conversation

gaborbernat commented Jan 20, 2019

obestwalter commented Jan 21, 2019

gaborbernat commented Jan 21, 2019 • edited Loading

asottile left a comment

Choose a reason for hiding this comment

asottile Jan 21, 2019

Choose a reason for hiding this comment

gaborbernat Jan 21, 2019

Choose a reason for hiding this comment

asottile Jan 21, 2019

Choose a reason for hiding this comment

obestwalter Jan 22, 2019

Choose a reason for hiding this comment

gaborbernat Jan 25, 2019

Choose a reason for hiding this comment

obestwalter commented Jan 22, 2019

obestwalter commented Jan 25, 2019

gaborbernat commented Feb 5, 2019

cjerdonek commented Mar 28, 2019 • edited Loading

cjerdonek commented Mar 28, 2019

gaborbernat commented Jan 21, 2019 •

edited

Loading

cjerdonek commented Mar 28, 2019 •

edited

Loading