Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #1236 typos in isolated.py build method #1235

Merged
merged 4 commits into from Mar 30, 2019
Merged

Fix #1236 typos in isolated.py build method #1235

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e673e1b
Reproduce build error when pyproject defines requirements for package
unmade Mar 30, 2019
e3a4882
Fix typos
unmade Mar 30, 2019
2ab9b41
Add changelog
unmade Mar 30, 2019
e94cf16
Skip test for win32 and py2
unmade Mar 30, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/tox/package/builder/isolated.py
View file
Open in desktop
Expand Up @@ -38,9 +38,9 @@ def build(config, session):
if pkg_resources.Requirement(r).key not in base_build_deps
]
if build_requires_dep:
with package_venv.newaction("build_requires", package_venv.envconfig.envdir) as action:
with package_venv.new_action("build_requires", package_venv.envconfig.envdir) as action:
package_venv.run_install_command(packages=build_requires_dep, action=action)
package_venv.finishvenv(package_venv)
package_venv.finishvenv()
return perform_isolated_build(build_info, package_venv, config.distdir, config.setupdir)


Expand Down
3 changes: 3 additions & 0 deletions tests/integration/test_package_int.py
View file
Open in desktop
Expand Up @@ -53,6 +53,9 @@ def test_package_flit(initproj, cmd):
author = "Happy Harry"
author-email = "happy@harry.com"
home-page = "https://github.com/happy-harry/is"
requires = [
"tox",
]
""",
".gitignore": ".tox",
},
Expand Down