Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove high constraint for importlib-metadata #1764

Merged
merged 1 commit into from
Jan 3, 2021

Conversation

pkolbus
Copy link

@pkolbus pkolbus commented Dec 24, 2020

Since importlib-metadata is a backport from CPython, new major versions are much more likely to be to adjust supported Python versions, and not change the API. Remove the upper bound on the version constraint.

Closes #1763.

Contribution checklist:

(also see CONTRIBUTING.rst for details)

  • wrote descriptive pull request text
  • added/updated test(s)
  • updated/extended the documentation
  • added relevant issue keyword
    in message body
  • added news fragment in changelog folder
    • fragment name: <issue number>.<type>.rst for example (588.bugfix.rst)
    • <type> is must be one of bugfix, feature, deprecation,breaking, doc, misc
    • if PR has no issue: consider creating one first or change it to the PR number after creating the PR
    • "sign" fragment with "by :user:<your username>"
    • please use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files - by :user:superuser."
    • also see examples
  • added yourself to CONTRIBUTORS (preserving alphabetical order)

Since importlib-metadata is a backport from CPython, new major versions
are much more likely to be to adjust supported Python versions, and not
change the API. Remove the upper bound on the version constraint.

Closes tox-dev#1763.
@gaborbernat gaborbernat merged commit 65641d4 into tox-dev:master Jan 3, 2021
ssbarnea pushed a commit to ssbarnea/tox that referenced this pull request Apr 19, 2021
Since importlib-metadata is a backport from CPython, new major versions
are much more likely to be to adjust supported Python versions, and not
change the API. Remove the upper bound on the version constraint.

Closes tox-dev#1763.
wouterdb added a commit to inmanta/inmanta-core that referenced this pull request Apr 19, 2021
to fix failed build on update of inmanta-dev-depenencies==1.32.0
and because tox-dev/tox#1764
inmantaci added a commit to inmanta/inmanta-core that referenced this pull request Apr 19, 2021
# Description

Allow dependabot to update importlib-metadata
to fix failed build on update of inmanta-dev-depenencies==1.32.0
and because tox-dev/tox#1764

Does this need to go through mergebot?

# Self Check:

Strike through any lines that are not applicable (`~~line~~`) then check the box

- [x] Changelog entry
e-carlin added a commit to radiasoft/pykern that referenced this pull request Jun 3, 2021
In tox 3.21.0 the high constraint for importlib-metadata was relaxed.
tox-dev/tox#1764

A matching PR was also merged in virtualenv.
pypa/virtualenv#2020

So, we no longer need to have a high constraint which should solve the
conflict (importlib-metadata 4.3.0 was installed but we expected <2).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow importlib-metadata v3
2 participants