Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Imply --parallel when --parallel-no-spinner is passed #3159

Merged
merged 10 commits into from Nov 29, 2023

Conversation

tusharsadhwani
Copy link
Contributor

@tusharsadhwani tusharsadhwani commented Nov 16, 2023

Resolves #3158

  • ran the linter to address style issues (tox -e fix)
  • wrote descriptive pull request text
  • ensured there are test(s) validating the fix
  • added news fragment in docs/changelog folder
  • updated/extended the documentation

@tusharsadhwani tusharsadhwani changed the title Fix no spinner Imply --parallel when --parallel-no-spinner is passed Nov 16, 2023
Copy link
Member

@gaborbernat gaborbernat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add test validating the change.

@tusharsadhwani tusharsadhwani marked this pull request as ready for review November 28, 2023 20:32
Copy link
Member

@gaborbernat gaborbernat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gaborbernat gaborbernat enabled auto-merge (squash) November 28, 2023 22:34
@gaborbernat gaborbernat merged commit 7bbf89e into tox-dev:main Nov 29, 2023
25 checks passed
@webknjaz
Copy link
Contributor

@gaborbernat looks like this caused a regression when the TOX_PARALLEL_NO_SPINNER=1 env var is set globally, in envs like CI.

@gaborbernat
Copy link
Member

@webknjaz can you detail the regression? @@tusharsadhwani can you take a look?

@tusharsadhwani
Copy link
Contributor Author

I can check. A brief explanation of the issue will help.

naa0yama pushed a commit to naa0yama/pythonboilerplate that referenced this pull request Jan 24, 2024
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [tox](https://togithub.com/tox-dev/tox)
([changelog](https://tox.wiki/en/latest/changelog.html)) | `~4.11.0` ->
`~4.12.0` |
[![age](https://developer.mend.io/api/mc/badges/age/pypi/tox/4.12.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/pypi/tox/4.12.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/pypi/tox/4.11.4/4.12.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/pypi/tox/4.11.4/4.12.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>tox-dev/tox (tox)</summary>

### [`v4.12.0`](https://togithub.com/tox-dev/tox/releases/tag/4.12.0)

[Compare
Source](https://togithub.com/tox-dev/tox/compare/4.11.4...4.12.0)

<!-- Release notes generated using configuration in .github/release.yml
at 4.12.0 -->

#### What's Changed

- Exclude bots from generated release notes by
[@&#8203;hugovk](https://togithub.com/hugovk) in
[tox-dev/tox#3163
- Imply `--parallel` when `--parallel-no-spinner` is passed by
[@&#8203;tusharsadhwani](https://togithub.com/tusharsadhwani) in
[tox-dev/tox#3159
- Fix 'open an issue' link in development.rst by
[@&#8203;TheRealFalcon](https://togithub.com/TheRealFalcon) in
[tox-dev/tox#3179
- Fix the CI by [@&#8203;gaborbernat](https://togithub.com/gaborbernat)
in
[tox-dev/tox#3183
- Always pass FORCE_COLOR & NO_COLOR to the environment by
[@&#8203;hashar](https://togithub.com/hashar) in
[tox-dev/tox#3172

#### New Contributors

- [@&#8203;tusharsadhwani](https://togithub.com/tusharsadhwani) made
their first contribution in
[tox-dev/tox#3159
- [@&#8203;TheRealFalcon](https://togithub.com/TheRealFalcon) made their
first contribution in
[tox-dev/tox#3179

**Full Changelog**:
tox-dev/tox@4.11.4...4.12.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/naa0yama/pythonboilerplate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xMjcuMCIsInVwZGF0ZWRJblZlciI6IjM3LjEyNy4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

--parallel-no-spinner should imply --parallel
3 participants